diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-05 17:08:07 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-05 17:08:07 +0000 |
| commit | 726bdbd79ab870b8f2d1b37ba72895cb68447a14 (patch) | |
| tree | 0d7504dc32dff8f2cd48c9973a1bc9f41518787d /chrome/browser/gtk/find_bar_gtk.h | |
| parent | 1456dad368c8998eaee08a30965c41ae55a32274 (diff) | |
| download | chromium_src-726bdbd79ab870b8f2d1b37ba72895cb68447a14.zip chromium_src-726bdbd79ab870b8f2d1b37ba72895cb68447a14.tar.gz chromium_src-726bdbd79ab870b8f2d1b37ba72895cb68447a14.tar.bz2 | |
Fix prepopulate value for Find and add browser tests for it.
Notable changes:
FindBarController now sets the prepopulate text during Show for the Find dialog, to fix regression 40121. It also checks not just the current find string (find_text()) but the previous one also (previous_find_text()) in MaybeSetPrepopulateText() because the current find string is blanked out when closing the Find window. And TabContents now makes sure previous_find_text() is never overwritten with an empty find_text value (to prevent the last search from being cleared if you open Find, close it without searching and open it again).
This changelist also adds automated tests for the codepaths above, which results in adding a GetFindText method to the FindBarTesting interface, to allow the tests to check what string is being shown to the user when the Find box opens.
BUG=40121
TEST=FindInPageControllerTest.Prepopulate* (three tests)
Review URL: http://codereview.chromium.org/1560012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43620 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/find_bar_gtk.h')
| -rw-r--r-- | chrome/browser/gtk/find_bar_gtk.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/gtk/find_bar_gtk.h b/chrome/browser/gtk/find_bar_gtk.h index c36ca50..3de3dfd 100644 --- a/chrome/browser/gtk/find_bar_gtk.h +++ b/chrome/browser/gtk/find_bar_gtk.h @@ -64,6 +64,7 @@ class FindBarGtk : public FindBar, // Methods from FindBarTesting. virtual bool GetFindBarWindowInfo(gfx::Point* position, bool* fully_visible); + virtual string16 GetFindText(); // Overridden from NotificationObserver: virtual void Observe(NotificationType type, |