diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 19:12:13 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 19:12:13 +0000 |
commit | 1490e88528ee6e8e450884016a861c9c1332d022 (patch) | |
tree | 5ee6b38126a67f3140c209fc1da5d8d36190740e /chrome/browser/gtk/location_bar_view_gtk.cc | |
parent | d9cd458aa54699e3ea3e01e88d8f75d82764796b (diff) | |
download | chromium_src-1490e88528ee6e8e450884016a861c9c1332d022.zip chromium_src-1490e88528ee6e8e450884016a861c9c1332d022.tar.gz chromium_src-1490e88528ee6e8e450884016a861c9c1332d022.tar.bz2 |
First run bubble polish:
- improve spacing and and sizing, both internally and externally (using windows as the guide)
- make legible for dark themes
- make show delay longer because it was too short on my machine (at least when using a Debug build).
Also explicitly set bookmark bubble labels black.
BUG=16782
TEST=none
Review URL: http://codereview.chromium.org/149664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20762 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/location_bar_view_gtk.cc')
-rw-r--r-- | chrome/browser/gtk/location_bar_view_gtk.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/browser/gtk/location_bar_view_gtk.cc b/chrome/browser/gtk/location_bar_view_gtk.cc index 38c2901..211f997 100644 --- a/chrome/browser/gtk/location_bar_view_gtk.cc +++ b/chrome/browser/gtk/location_bar_view_gtk.cc @@ -38,9 +38,11 @@ const int kBottomMargin = 1; const int kBorderThickness = 1; // Left margin of first run bubble. -const int kFirstRunBubbleLeftMargin = 20; +const int kFirstRunBubbleLeftMargin = 8; +// Extra vertical spacing for first run bubble. +const int kFirstRunBubbleTopMargin = 1; // Task delay (in milliseconds) to show first run bubble. -const int kFirstRunBubbleTaskDelay = 30; +const int kFirstRunBubbleTaskDelay = 200; // Left and right padding/margin. // no icon/text : 4px url_text 4px @@ -511,7 +513,8 @@ void LocationBarViewGtk::ShowFirstRunBubbleInternal(bool use_OEM_bubble) { // The bubble needs to be just below the Omnibox and slightly to the right // of star button, so shift x and y co-ordinates. x += widget()->allocation.x + kFirstRunBubbleLeftMargin; - y += widget()->allocation.y + widget()->allocation.height; + y += widget()->allocation.y + widget()->allocation.height + + kFirstRunBubbleTopMargin; FirstRunBubble::Show(profile_, GTK_WINDOW(gtk_widget_get_toplevel(widget())), |