diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 22:02:34 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 22:02:34 +0000 |
commit | f7f3a5f86a24f65666284802b51d0eaa5c9d7741 (patch) | |
tree | 5605992d68c1b48fe47f7fbee560dca7cda6693b /chrome/browser/gtk/location_bar_view_gtk.cc | |
parent | 32d371758f777380486f9c8ef28b1faca37ab26c (diff) | |
download | chromium_src-f7f3a5f86a24f65666284802b51d0eaa5c9d7741.zip chromium_src-f7f3a5f86a24f65666284802b51d0eaa5c9d7741.tar.gz chromium_src-f7f3a5f86a24f65666284802b51d0eaa5c9d7741.tar.bz2 |
This is the first part of the PageAction implementation. More work is required, but this is a good checkpoint.
Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api
This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader).
Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :)
BUG=None
TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA.
Review URL: http://codereview.chromium.org/99253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/location_bar_view_gtk.cc')
-rw-r--r-- | chrome/browser/gtk/location_bar_view_gtk.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/gtk/location_bar_view_gtk.cc b/chrome/browser/gtk/location_bar_view_gtk.cc index 4308c3b..11e4ac1 100644 --- a/chrome/browser/gtk/location_bar_view_gtk.cc +++ b/chrome/browser/gtk/location_bar_view_gtk.cc @@ -75,7 +75,7 @@ void LocationBarViewGtk::Init() { gtk_widget_set_app_paintable(alignment_.get(), TRUE); // Have GTK double buffer around the expose signal. gtk_widget_set_double_buffered(alignment_.get(), TRUE); - g_signal_connect(alignment_.get(), "expose-event", + g_signal_connect(alignment_.get(), "expose-event", G_CALLBACK(&HandleExposeThunk), this); gtk_container_add(GTK_CONTAINER(alignment_.get()), @@ -189,6 +189,10 @@ void LocationBarViewGtk::UpdateFeedIcon() { NOTIMPLEMENTED(); } +void LocationBarViewGtk::UpdatePageActions() { + NOTIMPLEMENTED(); +} + void LocationBarViewGtk::SaveStateToContents(TabContents* contents) { NOTIMPLEMENTED(); } |