summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/options/cookies_view.h
diff options
context:
space:
mode:
authormattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-23 01:51:33 +0000
committermattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-23 01:51:33 +0000
commit70853b00ae4f3a0b3c96978cfa4a5caeabacb60b (patch)
tree0963c7a0aeb351e66f7ece5f1ac52ec8be9f8667 /chrome/browser/gtk/options/cookies_view.h
parent7bf54f5ec74d9d3b3498c02b83da572a78fc1df6 (diff)
downloadchromium_src-70853b00ae4f3a0b3c96978cfa4a5caeabacb60b.zip
chromium_src-70853b00ae4f3a0b3c96978cfa4a5caeabacb60b.tar.gz
chromium_src-70853b00ae4f3a0b3c96978cfa4a5caeabacb60b.tar.bz2
Linux: fix crash in PopulateCookieDetails called by OnSelectionChanged callback
which can be called while the view and model are in inconsistent states. BUG=25535 TEST=open cookies manager, select all, remove all Review URL: http://codereview.chromium.org/334001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/options/cookies_view.h')
-rw-r--r--chrome/browser/gtk/options/cookies_view.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/gtk/options/cookies_view.h b/chrome/browser/gtk/options/cookies_view.h
index f47a95b..be9dbb8 100644
--- a/chrome/browser/gtk/options/cookies_view.h
+++ b/chrome/browser/gtk/options/cookies_view.h
@@ -33,6 +33,7 @@ class CookiesView : public gtk_tree::ModelAdapter::Delegate {
static void Show(Profile* profile);
// gtk_tree::ModelAdapter::Delegate implementation.
+ virtual void OnAnyModelUpdateStart();
virtual void OnAnyModelUpdate();
virtual void SetColumnValues(int row, GtkTreeIter* iter);
@@ -140,6 +141,7 @@ class CookiesView : public gtk_tree::ModelAdapter::Delegate {
friend class CookiesViewTest;
FRIEND_TEST(CookiesViewTest, Empty);
FRIEND_TEST(CookiesViewTest, RemoveAll);
+ FRIEND_TEST(CookiesViewTest, RemoveAllWithAllSelected);
FRIEND_TEST(CookiesViewTest, Remove);
FRIEND_TEST(CookiesViewTest, RemoveMultiple);
FRIEND_TEST(CookiesViewTest, RemoveDefaultSelection);