diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 02:47:37 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 02:47:37 +0000 |
commit | f749da537323d5dd900e636edeb111d8f52e7e9d (patch) | |
tree | 2d1da8ab40e8dc3aec06d53f29d2423702021d02 /chrome/browser/gtk/options | |
parent | cd69619bc053d527b7c82aac81c605157b28d01f (diff) | |
download | chromium_src-f749da537323d5dd900e636edeb111d8f52e7e9d.zip chromium_src-f749da537323d5dd900e636edeb111d8f52e7e9d.tar.gz chromium_src-f749da537323d5dd900e636edeb111d8f52e7e9d.tar.bz2 |
AutoFill profile shouldn't be saved when cancelled during initial setup.
Relanding after revert of: 46424
http://codereview.chromium.org/1902003
Fixing compile error on Windows.
For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
call now passes the new profile and credit card information to the dialog directly
instead of saving it to the database and then invoking the dialog. This facilitates
"Cancel" in the dialog where the new information is not persisted.
This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
out of the preferences dialog and into the AutoFillDialogController itself.
This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
call. More work is required on Linux and Windows to properly conform to this interface and
fix bug 41010. The Linux and Windows implementations will need to respect the new input
parameters |imported_profile| and |imported_credit_card|.
BUG=41010
TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters
Review URL: http://codereview.chromium.org/1952002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46430 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/options')
-rw-r--r-- | chrome/browser/gtk/options/content_page_gtk.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/gtk/options/content_page_gtk.cc b/chrome/browser/gtk/options/content_page_gtk.cc index 3b92201..770476d 100644 --- a/chrome/browser/gtk/options/content_page_gtk.cc +++ b/chrome/browser/gtk/options/content_page_gtk.cc @@ -215,7 +215,7 @@ void ContentPageGtk::OnPersonalDataLoaded() { // remove ourselves as observer. personal_data_->RemoveObserver(this); - ShowAutoFillDialog(NULL, personal_data_, profile()); + ShowAutoFillDialog(NULL, personal_data_, profile(), NULL, NULL); } GtkWidget* ContentPageGtk::InitPasswordSavingGroup() { |