diff options
author | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-04 21:27:23 +0000 |
---|---|---|
committer | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-04 21:27:23 +0000 |
commit | 48af406a5dc13be98bfef6c902843875399f1033 (patch) | |
tree | b676b12697276f11f9de767bf19174f30b27740a /chrome/browser/gtk/tab_contents_container_gtk.h | |
parent | 5318be8f3c27813755e08f759ed19809bc965a86 (diff) | |
download | chromium_src-48af406a5dc13be98bfef6c902843875399f1033.zip chromium_src-48af406a5dc13be98bfef6c902843875399f1033.tar.gz chromium_src-48af406a5dc13be98bfef6c902843875399f1033.tar.bz2 |
Revert "Convert tabcontentscontainer to use a vbox instead of a fixed. The"
This reverts commit r30843.
This broke the findbar/download shelf animation optimization. I
originally was doing this as part of fixing issue 26495, but I
found a different way.
TBR=estade
Review URL: http://codereview.chromium.org/366009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31003 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/tab_contents_container_gtk.h')
-rw-r--r-- | chrome/browser/gtk/tab_contents_container_gtk.h | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/chrome/browser/gtk/tab_contents_container_gtk.h b/chrome/browser/gtk/tab_contents_container_gtk.h index 6e1ad2a..8a7a8c7 100644 --- a/chrome/browser/gtk/tab_contents_container_gtk.h +++ b/chrome/browser/gtk/tab_contents_container_gtk.h @@ -58,6 +58,15 @@ class TabContentsContainerGtk : public NotificationObserver, // get notified. void TabContentsDestroyed(TabContents* contents); + // Implements our hack around a GtkFixed. The entire size of the GtkFixed is + // allocated to normal tab contents views, while the status bubble is + // informed of its parent and its parent's allocation (it makes a decision + // about layout later.) + static void OnFixedSizeAllocate( + GtkWidget* fixed, + GtkAllocation* allocation, + TabContentsContainerGtk* container); + // Handler for |floating_|'s "set-floating-position" signal. During this // callback, we manually set the position of the status bubble. static void OnSetFloatingPosition( @@ -78,9 +87,11 @@ class TabContentsContainerGtk : public NotificationObserver, // their positions manually set in OnSetFloatingPosition. OwnedWidgetGtk floating_; - // We insert TabContentsViewGtks into this container_. We only show one - // TabVontentsViewGtk at a time, so we can use a vbox or an hbox. - GtkWidget* container_; + // We insert and remove TabContents GtkWidgets into this fixed_. This should + // not be a GtkVBox since there were errors with timing where the vbox was + // horizontally split with the top half displaying the current TabContents + // and bottom half displaying the loading page. + GtkWidget* fixed_; DISALLOW_COPY_AND_ASSIGN(TabContentsContainerGtk); }; |