diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 21:26:06 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 21:26:06 +0000 |
commit | 054dc1e0e2f8e87500964bcab881174b9393d847 (patch) | |
tree | 296ce6f73bc5bf25bba7aa185f9092edb027c09c /chrome/browser/gtk/tabs/tab_strip_gtk.cc | |
parent | 78fb0befb7193b3a1093f9470686d755b623015f (diff) | |
download | chromium_src-054dc1e0e2f8e87500964bcab881174b9393d847.zip chromium_src-054dc1e0e2f8e87500964bcab881174b9393d847.tar.gz chromium_src-054dc1e0e2f8e87500964bcab881174b9393d847.tar.bz2 |
Fixes bug where highlighting the close XXX menu items in the context
menu should flash mini-tabs.
BUG=none
TEST=create three tabs, pin the first two, right click on the first
and hover over the context menu item close tabs to right,
make sure the second tab (which is pinned) doesn't highlight.
Review URL: http://codereview.chromium.org/1439001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42820 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/tabs/tab_strip_gtk.cc')
-rw-r--r-- | chrome/browser/gtk/tabs/tab_strip_gtk.cc | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/chrome/browser/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/gtk/tabs/tab_strip_gtk.cc index 1894d16..25a02c3 100644 --- a/chrome/browser/gtk/tabs/tab_strip_gtk.cc +++ b/chrome/browser/gtk/tabs/tab_strip_gtk.cc @@ -1134,16 +1134,10 @@ void TabStripGtk::ExecuteCommandForTab( void TabStripGtk::StartHighlightTabsForCommand( TabStripModel::ContextMenuCommand command_id, TabGtk* tab) { - if (command_id == TabStripModel::CommandCloseTabsOpenedBy) { - int index = GetIndexOfTab(tab); - if (model_->ContainsIndex(index)) { - std::vector<int> indices = model_->GetIndexesOpenedBy(index); - std::vector<int>::const_iterator iter = indices.begin(); - for (; iter != indices.end(); ++iter) { - int current_index = *iter; - DCHECK(current_index >= 0 && current_index < GetTabCount()); - } - } + if (command_id == TabStripModel::CommandCloseTabsOpenedBy || + command_id == TabStripModel::CommandCloseOtherTabs || + command_id == TabStripModel::CommandCloseTabsToRight) { + NOTIMPLEMENTED(); } } @@ -1159,6 +1153,7 @@ void TabStripGtk::StopHighlightTabsForCommand( void TabStripGtk::StopAllHighlighting() { // TODO(jhawkins): Hook up animations. + NOTIMPLEMENTED(); } void TabStripGtk::MaybeStartDrag(TabGtk* tab, const gfx::Point& point) { |