diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-14 15:14:53 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-14 15:14:53 +0000 |
| commit | bd63dc9cdf640a6d1e833ce0b5ed7ed9090973b0 (patch) | |
| tree | 149a64e70ca634bd43019d639d9ae29ca6d45a9a /chrome/browser/gtk/tabs | |
| parent | b39627f8eef41a2d4e1f4516bf905d6ad895e56b (diff) | |
| download | chromium_src-bd63dc9cdf640a6d1e833ce0b5ed7ed9090973b0.zip chromium_src-bd63dc9cdf640a6d1e833ce0b5ed7ed9090973b0.tar.gz chromium_src-bd63dc9cdf640a6d1e833ce0b5ed7ed9090973b0.tar.bz2 | |
Refactor the PlatformContext layer to have only one class.
Previously we had three classes of PlatformCanvas*, one for each platform. Then
we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the
specific platform.
This means that it was almost impossible to forward-declare PlatformCanvas and
there were a bunch of unnecessary includes of platform_canvas.h in header
files.
This change makes there be only one platform_canvas.h header with ifdefs, which
removes a decent amount of duplicated code. There is a platform-independent
file, and one platform-dependent file of platform_canvas for each platform.
I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in
this case I kept the separate headers since there was much less overlap.
I also broke out CanvasPaint into separate headers so this template doesn't
need to be included all over the project (only a couple of files actually need
it).
Review URL: http://codereview.chromium.org/125109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/tabs')
| -rwxr-xr-x[-rw-r--r--] | chrome/browser/gtk/tabs/tab_renderer_gtk.cc | 3 | ||||
| -rwxr-xr-x[-rw-r--r--] | chrome/browser/gtk/tabs/tab_strip_gtk.cc | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc index 0e8e873..112f33a 100644..100755 --- a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc +++ b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc @@ -4,6 +4,7 @@ #include "chrome/browser/gtk/tabs/tab_renderer_gtk.h" +#include "app/gfx/canvas_paint.h" #include "app/l10n_util.h" #include "app/resource_bundle.h" #include "chrome/browser/browser.h" @@ -510,7 +511,7 @@ void TabRendererGtk::MoveCloseButtonWidget() { void TabRendererGtk::PaintTab(GdkEventExpose* event) { gfx::CanvasPaint canvas(event, false); - if (canvas.isEmpty()) + if (canvas.is_empty()) return; // The tab is rendered into a windowless widget whose offset is at the diff --git a/chrome/browser/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/gtk/tabs/tab_strip_gtk.cc index 2b95e74..89a8fdc 100644..100755 --- a/chrome/browser/gtk/tabs/tab_strip_gtk.cc +++ b/chrome/browser/gtk/tabs/tab_strip_gtk.cc @@ -4,7 +4,7 @@ #include "chrome/browser/gtk/tabs/tab_strip_gtk.h" -#include "app/gfx/canvas.h" +#include "app/gfx/canvas_paint.h" #include "app/l10n_util.h" #include "app/resource_bundle.h" #include "app/slide_animation.h" |