Task Manager sorting:

- remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole
- allow sorting by the javascript memory column.
- allow sorting by goats teleported (useful for debugging)
- stabilize \# of goats teleported (remove observer effect)

BUG=42037
TEST=sort by these columns in the task manager

Review URL: http://codereview.chromium.org/1706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45139 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 1 deletions

diff --git a/chrome/browser/gtk/task_manager_gtk.cc b/chrome/browser/gtk/task_manager_gtk.cc
index 20840f3..aa8577b 100644
--- a/chrome/browser/gtk/task_manager_gtk.cc
+++ b/chrome/browser/gtk/task_manager_gtk.cc
@@ -519,6 +519,9 @@ void TaskManagerGtk::CreateTaskManagerTreeview() {
                                   kTaskManagerPrivateMem,
                                   ComparePrivateMemory, this, NULL);
   gtk_tree_sortable_set_sort_func(GTK_TREE_SORTABLE(process_list_sort_),
+                                  kTaskManagerJavaScriptMemory,
+                                  CompareV8Memory, this, NULL);
+  gtk_tree_sortable_set_sort_func(GTK_TREE_SORTABLE(process_list_sort_),
                                   kTaskManagerCPU,
                                   CompareCPU, this, NULL);
   gtk_tree_sortable_set_sort_func(GTK_TREE_SORTABLE(process_list_sort_),
@@ -624,7 +627,8 @@ std::string TaskManagerGtk::GetModelText(int row, int col_id) {
       return WideToUTF8(model_->GetResourceGoatsTeleported(row));
 
     default:
-      return WideToUTF8(model_->GetResourceStatsValue(row, col_id));
+      NOTREACHED();
+      return std::string();
   }
 }