diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-28 00:41:27 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-28 00:41:27 +0000 |
| commit | 5f2731c58384eb8b4b5102865dedbe9ade800d8a (patch) | |
| tree | 77b8ff1862e478f7a22931c97047653a5cff90e0 /chrome/browser/gtk | |
| parent | 4829cfadb745f47c441c709475e5f33a2b26d831 (diff) | |
| download | chromium_src-5f2731c58384eb8b4b5102865dedbe9ade800d8a.zip chromium_src-5f2731c58384eb8b4b5102865dedbe9ade800d8a.tar.gz chromium_src-5f2731c58384eb8b4b5102865dedbe9ade800d8a.tar.bz2 | |
Does two changes to appease chrome bot runs:
. Changes InfoBubble to properly initialize all fields in member
initializer list and set the delegate before show on the off chance
the bubble is deleted from show. This should no longer happen after
the second change.
. Only show the bookmark bubble if the browser window is active. I
experimented with conditionally enabling the star and this turns out
to be a bit error prone.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/31016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10659 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk')
| -rw-r--r-- | chrome/browser/gtk/browser_window_gtk.cc | 5 | ||||
| -rw-r--r-- | chrome/browser/gtk/browser_window_gtk.h | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc index 6535539..4135c72 100644 --- a/chrome/browser/gtk/browser_window_gtk.cc +++ b/chrome/browser/gtk/browser_window_gtk.cc @@ -204,6 +204,11 @@ void BrowserWindowGtk::Activate() { gtk_window_present(window_); } +bool BrowserWindowGtk::IsActive() const { + NOTIMPLEMENTED(); + return true; +} + void BrowserWindowGtk::FlashFrame() { // May not be respected by all window managers. gtk_window_set_urgency_hint(window_, TRUE); diff --git a/chrome/browser/gtk/browser_window_gtk.h b/chrome/browser/gtk/browser_window_gtk.h index adc1e91..07d3c97 100644 --- a/chrome/browser/gtk/browser_window_gtk.h +++ b/chrome/browser/gtk/browser_window_gtk.h @@ -33,6 +33,7 @@ class BrowserWindowGtk : public BrowserWindow, virtual void SetBounds(const gfx::Rect& bounds); virtual void Close(); virtual void Activate(); + virtual bool IsActive() const; virtual void FlashFrame(); virtual void* GetNativeHandle(); virtual BrowserWindowTesting* GetBrowserWindowTesting(); @@ -120,4 +121,3 @@ class BrowserWindowGtk : public BrowserWindow, }; #endif // CHROME_BROWSER_GTK_BROWSER_WINDOW_GTK_H_ - |