Bunch of Coverity fixes, rather minor severity.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159862

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 10 insertions, 5 deletions

diff --git a/chrome/browser/gtk/list_store_favicon_loader.cc b/chrome/browser/gtk/list_store_favicon_loader.cc
index 5a34dd0..eff00a5e 100644
--- a/chrome/browser/gtk/list_store_favicon_loader.cc
+++ b/chrome/browser/gtk/list_store_favicon_loader.cc
@@ -57,8 +57,11 @@ bool ListStoreFavIconLoader::GetRowByFavIconHandle(
 }
 
 void ListStoreFavIconLoader::OnGotFavIcon(
-    HistoryService::Handle handle, bool know_fav_icon,
-    scoped_refptr<RefCountedBytes> image_data, bool is_expired, GURL icon_url) {
+    HistoryService::Handle handle,
+    bool know_fav_icon,
+    scoped_refptr<RefCountedBytes> image_data,
+    bool is_expired,
+    const GURL& icon_url) {
   GtkTreeIter iter;
   if (!GetRowByFavIconHandle(handle, &iter))
     return;
diff --git a/chrome/browser/gtk/list_store_favicon_loader.h b/chrome/browser/gtk/list_store_favicon_loader.h
index 935c0f7..69d6ae9 100644
--- a/chrome/browser/gtk/list_store_favicon_loader.h
+++ b/chrome/browser/gtk/list_store_favicon_loader.h
@@ -35,9 +35,11 @@ class ListStoreFavIconLoader {
                              GtkTreeIter* result_iter);
 
   // Callback from HistoryService:::GetFavIconForURL
-  void OnGotFavIcon(HistoryService::Handle handle, bool know_fav_icon,
-                    scoped_refptr<RefCountedBytes> image_data, bool is_expired,
-                    GURL icon_url);
+  void OnGotFavIcon(HistoryService::Handle handle,
+                    bool know_fav_icon,
+                    scoped_refptr<RefCountedBytes> image_data,
+                    bool is_expired,
+                    const GURL& icon_url);
 
   // The list store we are loading favicons into.
   GtkListStore* list_store_;