diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 01:55:48 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 01:55:48 +0000 |
commit | 7991a2336f3e5b975d5f31ffa24f129eb8bf32ad (patch) | |
tree | 52df10a63cfa787c42796566263fcb81c6517d4f /chrome/browser/history/history.h | |
parent | 6e82c3c6c3860a1005c96f4f6c138aa79a56d685 (diff) | |
download | chromium_src-7991a2336f3e5b975d5f31ffa24f129eb8bf32ad.zip chromium_src-7991a2336f3e5b975d5f31ffa24f129eb8bf32ad.tar.gz chromium_src-7991a2336f3e5b975d5f31ffa24f129eb8bf32ad.tar.bz2 |
Seventh patch in making destructors of refcounted objects private.
BUG=26749
Review URL: http://codereview.chromium.org/371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history/history.h')
-rw-r--r-- | chrome/browser/history/history.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h index 6a886b9..1afe44d 100644 --- a/chrome/browser/history/history.h +++ b/chrome/browser/history/history.h @@ -59,8 +59,6 @@ class URLDatabase; // on the main thread. class HistoryDBTask : public base::RefCountedThreadSafe<HistoryDBTask> { public: - virtual ~HistoryDBTask() {} - // Invoked on the database thread. The return value indicates whether the // task is done. A return value of true signals the task is done and // RunOnDBThread should NOT be invoked again. A return value of false @@ -73,6 +71,11 @@ class HistoryDBTask : public base::RefCountedThreadSafe<HistoryDBTask> { // only invoked if the request was not canceled and returned true from // RunOnDBThread. virtual void DoneRunOnMainThread() = 0; + + protected: + friend class base::RefCountedThreadSafe<HistoryDBTask>; + + virtual ~HistoryDBTask() {} }; // The history service records page titles, and visit times, as well as @@ -95,7 +98,6 @@ class HistoryService : public CancelableRequestProvider, explicit HistoryService(Profile* profile); // The empty constructor is provided only for testing. HistoryService(); - ~HistoryService(); // Initializes the history service, returning true on success. On false, do // not call any other functions. The given directory will be used for storing @@ -521,6 +523,7 @@ class HistoryService : public CancelableRequestProvider, private: class BackendDelegate; + friend class base::RefCountedThreadSafe<HistoryService>; friend class BackendDelegate; friend class FaviconService; friend class history::HistoryBackend; @@ -534,6 +537,8 @@ class HistoryService : public CancelableRequestProvider, friend class FavIconRequest; friend class TestingProfile; + ~HistoryService(); + // These are not currently used, hopefully we can do something in the future // to ensure that the most important things happen first. enum SchedulePriority { |