diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-19 21:14:50 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-19 21:14:50 +0000 |
commit | c96d2673e03f87d0a39efe047df517a87fdd9ec7 (patch) | |
tree | 75e2362bcae09b90598fa2c17a19c6ad5c9306bf /chrome/browser/history/history.h | |
parent | 041591e177a759271eaf6b334a87f678bb2e9d62 (diff) | |
download | chromium_src-c96d2673e03f87d0a39efe047df517a87fdd9ec7.zip chromium_src-c96d2673e03f87d0a39efe047df517a87fdd9ec7.tar.gz chromium_src-c96d2673e03f87d0a39efe047df517a87fdd9ec7.tar.bz2 |
Revert 56742 - A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history/history.h')
-rw-r--r-- | chrome/browser/history/history.h | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h index 5bc3b7f..c142c97 100644 --- a/chrome/browser/history/history.h +++ b/chrome/browser/history/history.h @@ -185,7 +185,6 @@ class HistoryService : public CancelableRequestProvider, const GURL& referrer, PageTransition::Type transition, const history::RedirectList& redirects, - history::VisitSource visit_source, bool did_replace_entry); // For adding pages to history with a specific time. This is for testing @@ -197,13 +196,12 @@ class HistoryService : public CancelableRequestProvider, const GURL& referrer, PageTransition::Type transition, const history::RedirectList& redirects, - history::VisitSource visit_source, bool did_replace_entry); // For adding pages to history where no tracking information can be done. - void AddPage(const GURL& url, history::VisitSource visit_source) { - AddPage(url, NULL, 0, GURL(), PageTransition::LINK, - history::RedirectList(), visit_source, false); + void AddPage(const GURL& url) { + AddPage(url, NULL, 0, GURL(), PageTransition::LINK, history::RedirectList(), + false); } // Sets the title for the given page. The page should be in history. If it @@ -537,12 +535,10 @@ class HistoryService : public CancelableRequestProvider, int visit_count, int typed_count, base::Time last_visit, - bool hidden, - history::VisitSource visit_source); + bool hidden); // The same as AddPageWithDetails() but takes a vector. - void AddPagesWithDetails(const std::vector<history::URLRow>& info, - history::VisitSource visit_source); + void AddPagesWithDetails(const std::vector<history::URLRow>& info); // Starts the TopSites migration in the HistoryThread. Called by the // BackendDelegate. |