diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 07:46:37 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 07:46:37 +0000 |
| commit | 3e377c5a80be45d36a6015c80d9e2dae525cf042 (patch) | |
| tree | 089f72c86a2f2314e527f2e95a3903253fbcf51a /chrome/browser/history/history.h | |
| parent | a42d22a1abe11d4f138c4c0870568be69bad5301 (diff) | |
| download | chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.zip chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.gz chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.bz2 | |
Revert of r22559.
This caused an easily reproducible crash:
1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash
The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history/history.h')
| -rw-r--r-- | chrome/browser/history/history.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h index caac179..0643139 100644 --- a/chrome/browser/history/history.h +++ b/chrome/browser/history/history.h @@ -270,8 +270,8 @@ class HistoryService : public CancelableRequestProvider, // some reason, success will additionally be false. If the given page // has redirected to multiple destinations, this will pick a random one. typedef Callback4<Handle, - const GURL&, // from_url - bool, // success + GURL, // from_url + bool, // success history::RedirectList*>::Type QueryRedirectsCallback; @@ -356,7 +356,7 @@ class HistoryService : public CancelableRequestProvider, bool, // know_favicon scoped_refptr<RefCountedBytes>, // data bool, // expired - const GURL&>::Type // url of the favicon + GURL>::Type // url of the favicon FavIconDataCallback; // Requests the favicon. FavIconConsumer is notified |