diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-20 20:19:11 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-20 20:19:11 +0000 |
| commit | c5e8f606d15bd2033cef185e7ced6a3751a753b2 (patch) | |
| tree | 49364762475bf84564df93e4c829125441468cce /chrome/browser/history/top_sites.cc | |
| parent | 7358d531be6d70c5542ea6a5bac77508ca9843fd (diff) | |
| download | chromium_src-c5e8f606d15bd2033cef185e7ced6a3751a753b2.zip chromium_src-c5e8f606d15bd2033cef185e7ced6a3751a753b2.tar.gz chromium_src-c5e8f606d15bd2033cef185e7ced6a3751a753b2.tar.bz2 | |
Most Visited: remove over-eager optimization that causes a lot of blank thumbnails
after storing thumbnails in the thread safe cache, we were removing those which are not currently in the top 8. This sucks because then when you blacklist a site, the thumbnail for the replacement is not in the cache, so we use a default image even though the thumbnail is available in the DB. The optimization hardly saves us anything, as the number of cached thumbnails is capped to begin with, and we are only trimming to 8, and it's ref counted data anyway so it's already resident somewhere else in memory either way.
BUG=none
TEST=blacklist a site. Most likely you will get an actual thumbnail for its replacement
Review URL: http://codereview.chromium.org/8355031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106559 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history/top_sites.cc')
| -rw-r--r-- | chrome/browser/history/top_sites.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/browser/history/top_sites.cc b/chrome/browser/history/top_sites.cc index f85d1d8..2bea2d3 100644 --- a/chrome/browser/history/top_sites.cc +++ b/chrome/browser/history/top_sites.cc @@ -948,7 +948,6 @@ void TopSites::ResetThreadSafeCache() { void TopSites::ResetThreadSafeImageCache() { base::AutoLock lock(lock_); thread_safe_cache_->SetThumbnails(cache_->images()); - thread_safe_cache_->RemoveUnreferencedThumbnails(); } void TopSites::NotifyTopSitesChanged() { |