diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-27 16:15:44 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-27 16:15:44 +0000 |
| commit | 0bfc29a5e1dc622ef1ca3601296738112a9a9abf (patch) | |
| tree | c2dc97f51a06d57db01cee5e1164cf0b81f9dc2a /chrome/browser/history/visit_database.cc | |
| parent | 930709556e52f09d355aaf0c7b00e90d6042d4d9 (diff) | |
| download | chromium_src-0bfc29a5e1dc622ef1ca3601296738112a9a9abf.zip chromium_src-0bfc29a5e1dc622ef1ca3601296738112a9a9abf.tar.gz chromium_src-0bfc29a5e1dc622ef1ca3601296738112a9a9abf.tar.bz2 | |
Searching by keyword now generates a visit against the site with a
transition type of TAB_TO_SEARCH. This visit increments the typed
count and ensures if you use TAB_TO_SEARCH you still get autocompleted
to the site.
I'll add some tests for this, but want to make sure we're ok with it
before I do that.
BUG=3633
TEST=will be covered by unit tests.
Review URL: http://codereview.chromium.org/93087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history/visit_database.cc')
| -rw-r--r-- | chrome/browser/history/visit_database.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/history/visit_database.cc b/chrome/browser/history/visit_database.cc index 4e796de..c118bf2 100644 --- a/chrome/browser/history/visit_database.cc +++ b/chrome/browser/history/visit_database.cc @@ -224,7 +224,8 @@ void VisitDatabase::GetVisibleVisitsInRange(Time begin_time, Time end_time, "SELECT" HISTORY_VISIT_ROW_FIELDS "FROM visits " "WHERE visit_time >= ? AND visit_time < ? " "AND (transition & ?) != 0 " // CHAIN_END - "AND (transition & ?) NOT IN (?, ?) " // NO SUBFRAME + "AND (transition & ?) NOT IN (?, ?, ?) " // NO SUBFRAME or + // KEYWORD_GENERATED "ORDER BY visit_time DESC, id DESC"); if (!statement.is_valid()) return; @@ -239,6 +240,7 @@ void VisitDatabase::GetVisibleVisitsInRange(Time begin_time, Time end_time, statement->bind_int(3, PageTransition::CORE_MASK); statement->bind_int(4, PageTransition::AUTO_SUBFRAME); statement->bind_int(5, PageTransition::MANUAL_SUBFRAME); + statement->bind_int(6, PageTransition::KEYWORD_GENERATED); std::set<URLID> found_urls; while (statement->step() == SQLITE_ROW) { |