Change NOTREACHED() to DLOG() in TextDatabaseManager::AddPageData.

It's possible that if Chrome's history is being updated (e.g., after
having navigated to a URL), and the browsing history is quickly
deleted before all history updates have been completely performed,
then a stale history update may be attempted, leading to a NOTREACHED
that was manifesting through pyauto automation.  This CL changes
the NOTREACHED to a DLOG, preventing the browser process from dying
when this situation occurs.

BUG=88128,chromium-os:14394
TEST=None

Review URL: http://codereview.chromium.org/7981048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103482 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 1 deletions

diff --git a/chrome/browser/history/text_database_manager.cc b/chrome/browser/history/text_database_manager.cc
index 1403ebe..df47bc7 100644
--- a/chrome/browser/history/text_database_manager.cc
+++ b/chrome/browser/history/text_database_manager.cc
@@ -292,7 +292,11 @@ bool TextDatabaseManager::AddPageData(const GURL& url,
     // We're supposed to update the visit database, so load the visit.
     VisitRow row;
     if (!visit_database_->GetRowForVisit(visit_id, &row)) {
-      NOTREACHED() << "Could not find requested visit #" << visit_id;
+      // This situation can occur if Chrome's history is in the process of
+      // being updated, and then the browsing history is deleted before all
+      // updates have been completely performed.  In this case, a stale update
+      // to the database is attempted, leading to the warning below.
+      DLOG(WARNING) << "Could not find requested visit #" << visit_id;
       return false;
     }