diff options
| author | macourteau@chromium.org <macourteau@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 22:31:55 +0000 |
|---|---|---|
| committer | macourteau@chromium.org <macourteau@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 22:31:55 +0000 |
| commit | 5579ed0b8fe574ad142cd88d44642ecb4d2f7e50 (patch) | |
| tree | e3dbd73eb7aa5ad108a8d5b711c6901125b011dc /chrome/browser/history | |
| parent | fcbbd1fdf87fee30fca225b5bfb2ae7d52227058 (diff) | |
| download | chromium_src-5579ed0b8fe574ad142cd88d44642ecb4d2f7e50.zip chromium_src-5579ed0b8fe574ad142cd88d44642ecb4d2f7e50.tar.gz chromium_src-5579ed0b8fe574ad142cd88d44642ecb4d2f7e50.tar.bz2 | |
Uses segment ID instead of URL ID to fetch visit information. The score map
is computed for segment IDs, and not URL IDs.
BUG=none
TEST=Open chrome://suggestions-internals/, and verify that there is data in all
of the extended_info.* columns, for every row that has data in at least one of
those columns (extended_info.*).
Review URL: https://chromiumcodereview.appspot.com/10538006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140637 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history')
| -rw-r--r-- | chrome/browser/history/history_backend.cc | 5 | ||||
| -rw-r--r-- | chrome/browser/history/history_types.h | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc index 21c21e3..8934edc 100644 --- a/chrome/browser/history/history_backend.cc +++ b/chrome/browser/history/history_backend.cc @@ -1548,7 +1548,8 @@ void HistoryBackend::QueryFilteredURLs( if (extended_info) { VisitVector visits; - db_->GetVisitsForURL(current_data->GetID(), &visits); + db_->GetVisitsForURL( + db_->GetSegmentRepresentationURL(current_data->GetID()), &visits); if (visits.size() > 0) { url.extended_info.total_visits = visits.size(); for (size_t i = 0; i < visits.size(); ++i) { @@ -1558,7 +1559,7 @@ void HistoryBackend::QueryFilteredURLs( url.extended_info.last_visit_time = visits[i].visit_time; } } - // TODO(macourteau): implement the url.debug.visits stat. + // TODO(macourteau): implement the url.extended_info.visits stat. } } result.push_back(url); diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h index 478e38f..0c0fdfb 100644 --- a/chrome/browser/history/history_types.h +++ b/chrome/browser/history/history_types.h @@ -202,7 +202,7 @@ typedef std::vector<URLRow> URLRows; enum VisitSource { SOURCE_SYNCED = 0, // Synchronized from somewhere else. SOURCE_BROWSED = 1, // User browsed. - SOURCE_EXTENSION = 2, // Added by an externsion. + SOURCE_EXTENSION = 2, // Added by an extension. SOURCE_FIREFOX_IMPORTED = 3, SOURCE_IE_IMPORTED = 4, SOURCE_SAFARI_IMPORTED = 5, |