diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-24 21:14:53 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-24 21:14:53 +0000 |
commit | 47e870bf26f0c01dafe611ec03c0139c735063df (patch) | |
tree | 43b29b36654d896cf3fd1bd3cc27b830c63522b0 /chrome/browser/history | |
parent | 883844f40f19b80880e0730a8e2836e6383d1400 (diff) | |
download | chromium_src-47e870bf26f0c01dafe611ec03c0139c735063df.zip chromium_src-47e870bf26f0c01dafe611ec03c0139c735063df.tar.gz chromium_src-47e870bf26f0c01dafe611ec03c0139c735063df.tar.bz2 |
Revert 184352
> Add utf_string_conversions to base namespace.
>
> This adds "using"s for all functions so those can be fixed in a separate pass.
>
> This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/12314090
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12315071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/history')
-rw-r--r-- | chrome/browser/history/history_publisher_win.cc | 6 | ||||
-rw-r--r-- | chrome/browser/history/in_memory_database.cc | 2 | ||||
-rw-r--r-- | chrome/browser/history/query_parser_unittest.cc | 8 | ||||
-rw-r--r-- | chrome/browser/history/thumbnail_database.cc | 2 |
4 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/history/history_publisher_win.cc b/chrome/browser/history/history_publisher_win.cc index 1d7d4a5..31e5241 100644 --- a/chrome/browser/history/history_publisher_win.cc +++ b/chrome/browser/history/history_publisher_win.cc @@ -101,12 +101,12 @@ void HistoryPublisher::PublishDataToIndexers(const PageData& page_data) // Send data to registered indexers. base::win::ScopedVariant time(var_time, VT_DATE); - base::win::ScopedBstr url(base::ASCIIToWide(page_data.url.spec()).c_str()); + base::win::ScopedBstr url(ASCIIToWide(page_data.url.spec()).c_str()); base::win::ScopedBstr html(page_data.html); base::win::ScopedBstr title(page_data.title); - // Don't send a NULL string through base::ASCIIToWide. + // Don't send a NULL string through ASCIIToWide. base::win::ScopedBstr format(page_data.thumbnail_format ? - base::ASCIIToWide(page_data.thumbnail_format).c_str() : + ASCIIToWide(page_data.thumbnail_format).c_str() : NULL); base::win::ScopedVariant psa(thumbnail_arr.m_psa); for (size_t i = 0; i < indexers_.size(); ++i) { diff --git a/chrome/browser/history/in_memory_database.cc b/chrome/browser/history/in_memory_database.cc index f807e6f..02b335f 100644 --- a/chrome/browser/history/in_memory_database.cc +++ b/chrome/browser/history/in_memory_database.cc @@ -72,7 +72,7 @@ bool InMemoryDatabase::InitFromDisk(const base::FilePath& history_name) { #if defined(OS_POSIX) attach.BindString(0, history_name.value()); #else - attach.BindString(0, base::WideToUTF8(history_name.value())); + attach.BindString(0, WideToUTF8(history_name.value())); #endif if (!attach.Run()) return false; diff --git a/chrome/browser/history/query_parser_unittest.cc b/chrome/browser/history/query_parser_unittest.cc index 860cab8..0b34e74 100644 --- a/chrome/browser/history/query_parser_unittest.cc +++ b/chrome/browser/history/query_parser_unittest.cc @@ -39,12 +39,12 @@ TEST_F(QueryParserTest, SimpleQueries) { // the minimum is 2 while for other scripts, it's 3. EXPECT_EQ("f b", QueryToString(" f b")); // KA JANG - EXPECT_EQ(base::WideToUTF8(L"\xAC00 \xC7A5"), - QueryToString(base::WideToUTF8(L" \xAC00 \xC7A5"))); + EXPECT_EQ(WideToUTF8(L"\xAC00 \xC7A5"), + QueryToString(WideToUTF8(L" \xAC00 \xC7A5"))); EXPECT_EQ("foo* bar*", QueryToString(" foo bar ")); // KA-JANG BICH-GO - EXPECT_EQ(base::WideToUTF8(L"\xAC00\xC7A5* \xBE5B\xACE0*"), - QueryToString(base::WideToUTF8(L"\xAC00\xC7A5 \xBE5B\xACE0"))); + EXPECT_EQ(WideToUTF8(L"\xAC00\xC7A5* \xBE5B\xACE0*"), + QueryToString(WideToUTF8(L"\xAC00\xC7A5 \xBE5B\xACE0"))); } // Quoted substring parsing. diff --git a/chrome/browser/history/thumbnail_database.cc b/chrome/browser/history/thumbnail_database.cc index f258d96..73513e3 100644 --- a/chrome/browser/history/thumbnail_database.cc +++ b/chrome/browser/history/thumbnail_database.cc @@ -990,7 +990,7 @@ bool ThumbnailDatabase::RenameAndDropThumbnails( #if defined(OS_POSIX) attach.BindString(0, new_db_file.value()); #else - attach.BindString(0, base::WideToUTF8(new_db_file.value())); + attach.BindString(0, WideToUTF8(new_db_file.value())); #endif if (!attach.Run()) { |