diff options
| author | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-06 16:28:57 +0000 |
|---|---|---|
| committer | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-06 16:28:57 +0000 |
| commit | f6061aeddb0c01a9c80aabf769b04c96a31f066f (patch) | |
| tree | 85760537cc584c6ead179fa788047c10da618a0a /chrome/browser/importer/importer_unittest.cc | |
| parent | 5b137dcbe79a56673fbed5f23d3a2480270fce13 (diff) | |
| download | chromium_src-f6061aeddb0c01a9c80aabf769b04c96a31f066f.zip chromium_src-f6061aeddb0c01a9c80aabf769b04c96a31f066f.tar.gz chromium_src-f6061aeddb0c01a9c80aabf769b04c96a31f066f.tar.bz2 | |
(please review thoroughly since this touches many moving parts).
Refactor ImporterHost as preparation for OOPprofile import.
ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process.
This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc.
ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world.
ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface.
There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can.
BUG=14458
TEST=Profile import should continue to work on Windows/Linux & Mac.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996
Review URL: http://codereview.chromium.org/242091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer/importer_unittest.cc')
| -rw-r--r-- | chrome/browser/importer/importer_unittest.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/importer/importer_unittest.cc b/chrome/browser/importer/importer_unittest.cc index 739465d..b6ef1f6 100644 --- a/chrome/browser/importer/importer_unittest.cc +++ b/chrome/browser/importer/importer_unittest.cc @@ -20,6 +20,7 @@ #include "base/stl_util-inl.h" #include "chrome/browser/importer/ie_importer.h" #include "chrome/browser/importer/importer.h" +#include "chrome/browser/importer/importer_bridge.h" #include "chrome/browser/password_manager/ie7_password.h" #include "chrome/browser/profile.h" #include "chrome/browser/search_engines/template_url.h" |