diff options
author | brg@chromium.com <brg@chromium.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 03:31:06 +0000 |
---|---|---|
committer | brg@chromium.com <brg@chromium.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 03:31:06 +0000 |
commit | 488e909e924ff53ad480a8516cccdc7ab64f43fe (patch) | |
tree | 4b0478167272fa7e0c1eaefe56fc3af1430fa13f /chrome/browser/importer/importer_unittest.cc | |
parent | ebc39d54914fe7d6761ac976a9a8d71619f12880 (diff) | |
download | chromium_src-488e909e924ff53ad480a8516cccdc7ab64f43fe.zip chromium_src-488e909e924ff53ad480a8516cccdc7ab64f43fe.tar.gz chromium_src-488e909e924ff53ad480a8516cccdc7ab64f43fe.tar.bz2 |
Toolbar Importer Pass2
Implements the following features
1. Toolbar import always available after first run
2. Deduping of imported favorites
3. Removes attempt to import favicons (not supported through Toolbar UI atm)
4. Always the user to cancel from the UI safely
5. Unittests for parsing
(TODO Better UI for login)
Review URL: http://codereview.chromium.org/9414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer/importer_unittest.cc')
-rw-r--r-- | chrome/browser/importer/importer_unittest.cc | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/chrome/browser/importer/importer_unittest.cc b/chrome/browser/importer/importer_unittest.cc index d30cdb8..f75aa4f 100644 --- a/chrome/browser/importer/importer_unittest.cc +++ b/chrome/browser/importer/importer_unittest.cc @@ -189,7 +189,9 @@ class TestObserver : public ProfileWriter, ++history_count_; } - virtual void AddBookmarkEntry(const std::vector<BookmarkEntry>& bookmark) { + virtual void AddBookmarkEntry( + const std::vector<BookmarkEntry>& bookmark, + bool check_duplicates) { // Importer should import the IE Favorites folder the same as the list. for (size_t i = 0; i < bookmark.size(); ++i) { if (FindBookmarkEntry(bookmark[i], kIEBookmarks, @@ -542,7 +544,8 @@ class FirefoxObserver : public ProfileWriter, ++history_count_; } - virtual void AddBookmarkEntry(const std::vector<BookmarkEntry>& bookmark) { + virtual void AddBookmarkEntry(const std::vector<BookmarkEntry>& bookmark, + bool check_duplicates) { for (size_t i = 0; i < bookmark.size(); ++i) { if (FindBookmarkEntry(bookmark[i], kFirefox2Bookmarks, arraysize(kFirefox2Bookmarks))) @@ -741,7 +744,8 @@ class Firefox3Observer : public ProfileWriter, ++history_count_; } - virtual void AddBookmarkEntry(const std::vector<BookmarkEntry>& bookmark) { + virtual void AddBookmarkEntry(const std::vector<BookmarkEntry>& bookmark, + bool check_duplicates) { for (size_t i = 0; i < bookmark.size(); ++i) { if (FindBookmarkEntry(bookmark[i], kFirefox3Bookmarks, arraysize(kFirefox3Bookmarks))) |