diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 20:06:30 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 20:06:30 +0000 |
commit | 20f0487a5b73e8071af2612150301b0942cbf0e2 (patch) | |
tree | ecee69b28f16712bdc1558ac0a015ac80095c761 /chrome/browser/importer/profile_writer.h | |
parent | 167b0dd17d5ed57ff293b6480ccaed706e0bc9cb (diff) | |
download | chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.zip chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.gz chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.bz2 |
FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on
a whole bunch of virtual dtors that were missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3522004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer/profile_writer.h')
-rw-r--r-- | chrome/browser/importer/profile_writer.h | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/chrome/browser/importer/profile_writer.h b/chrome/browser/importer/profile_writer.h index a8571cb..5c0e25c 100644 --- a/chrome/browser/importer/profile_writer.h +++ b/chrome/browser/importer/profile_writer.h @@ -48,19 +48,13 @@ class ProfileWriter : public base::RefCountedThreadSafe<ProfileWriter> { BOOKMARK_BAR_DISABLED = 1 << 2 }; - explicit ProfileWriter(Profile* profile) : profile_(profile) {} - - // These functions return true if the corresponding model has been loaded. - // If the models haven't been loaded, the importer waits to run until they've - // completed. - virtual bool BookmarkModelIsLoaded() const; - virtual bool TemplateURLModelIsLoaded() const; - // A bookmark entry. // TODO(mirandac): remove instances of wstring from ProfileWriter // (http://crbug.com/43460). struct BookmarkEntry { - BookmarkEntry() : in_toolbar(false) {} + BookmarkEntry(); + ~BookmarkEntry(); + bool in_toolbar; GURL url; std::vector<std::wstring> path; @@ -68,6 +62,14 @@ class ProfileWriter : public base::RefCountedThreadSafe<ProfileWriter> { base::Time creation_time; }; + explicit ProfileWriter(Profile* profile); + + // These functions return true if the corresponding model has been loaded. + // If the models haven't been loaded, the importer waits to run until they've + // completed. + virtual bool BookmarkModelIsLoaded() const; + virtual bool TemplateURLModelIsLoaded() const; + // Helper methods for adding data to local stores. virtual void AddPasswordForm(const webkit_glue::PasswordForm& form); #if defined(OS_WIN) @@ -115,7 +117,7 @@ class ProfileWriter : public base::RefCountedThreadSafe<ProfileWriter> { protected: friend class base::RefCountedThreadSafe<ProfileWriter>; - virtual ~ProfileWriter() {} + virtual ~ProfileWriter(); private: // Generates a unique folder name. If folder_name is not unique, then this |