summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-24 18:18:34 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-24 18:18:34 +0000
commitc530c85aa67a10aac9a77d10970951633ff686d9 (patch)
tree5b0943bd7369f48053075a75db9cf6e5a0d1514d /chrome/browser/importer
parentb4c95f61571c24ea1fc15fed0eda1269fe75d94b (diff)
downloadchromium_src-c530c85aa67a10aac9a77d10970951633ff686d9.zip
chromium_src-c530c85aa67a10aac9a77d10970951633ff686d9.tar.gz
chromium_src-c530c85aa67a10aac9a77d10970951633ff686d9.tar.bz2
Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592
Review URL: http://codereview.chromium.org/8373021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer')
-rw-r--r--chrome/browser/importer/toolbar_importer.cc13
-rw-r--r--chrome/browser/importer/toolbar_importer.h13
2 files changed, 9 insertions, 17 deletions
diff --git a/chrome/browser/importer/toolbar_importer.cc b/chrome/browser/importer/toolbar_importer.cc
index 3debf4c..c36d8a5 100644
--- a/chrome/browser/importer/toolbar_importer.cc
+++ b/chrome/browser/importer/toolbar_importer.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/libxml_utils.h"
#include "content/browser/browser_thread.h"
+#include "content/common/net/url_fetcher.h"
#include "grit/generated_resources.h"
// Toolbar5Importer
@@ -96,25 +97,21 @@ void Toolbar5Importer::Cancel() {
}
}
-void Toolbar5Importer::OnURLFetchComplete(
- const URLFetcher* source,
- const GURL& url,
- const net::URLRequestStatus& status,
- int response_code,
- const net::ResponseCookies& cookies,
- const std::string& data) {
+void Toolbar5Importer::OnURLFetchComplete(const URLFetcher* source) {
if (cancelled()) {
EndImport();
return;
}
- if (200 != response_code) { // HTTP/Ok
+ if (200 != source->response_code()) { // HTTP/Ok
// Cancelling here will update the UI and bypass the rest of bookmark
// import.
EndImportBookmarks();
return;
}
+ std::string data;
+ source->GetResponseAsString(&data);
switch (state_) {
case GET_AUTHORIZATION_TOKEN:
GetBookmarkDataFromServer(data);
diff --git a/chrome/browser/importer/toolbar_importer.h b/chrome/browser/importer/toolbar_importer.h
index fd1fcf0..6e09c60 100644
--- a/chrome/browser/importer/toolbar_importer.h
+++ b/chrome/browser/importer/toolbar_importer.h
@@ -18,7 +18,7 @@
#include "base/string16.h"
#include "chrome/browser/importer/importer.h"
#include "chrome/browser/importer/profile_writer.h"
-#include "content/common/net/url_fetcher.h"
+#include "content/public/common/url_fetcher_delegate.h"
class ImporterBridge;
class XmlReader;
@@ -29,7 +29,7 @@ class XmlReader;
// Toolbar5Importer should not have StartImport called more than once. Futher
// if StartImport is called, then the class must not be destroyed until it has
// either completed or Toolbar5Importer->Cancel() has been called.
-class Toolbar5Importer : public URLFetcher::Delegate, public Importer {
+class Toolbar5Importer : public content::URLFetcherDelegate, public Importer {
public:
Toolbar5Importer();
@@ -46,13 +46,8 @@ class Toolbar5Importer : public URLFetcher::Delegate, public Importer {
// to cancel network retrieval.
virtual void Cancel();
- // URLFetcher::Delegate method called back from the URLFetcher object.
- virtual void OnURLFetchComplete(const URLFetcher* source,
- const GURL& url,
- const net::URLRequestStatus& status,
- int response_code,
- const net::ResponseCookies& cookies,
- const std::string& data);
+ // content::URLFetcherDelegate method called back from the URLFetcher object.
+ virtual void OnURLFetchComplete(const URLFetcher* source);
private:
FRIEND_TEST_ALL_PREFIXES(Toolbar5ImporterTest, BookmarkParse);