summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
diff options
context:
space:
mode:
authornsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-18 00:06:00 +0000
committernsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-18 00:06:00 +0000
commit7a89f55023d63bb8d2ffb8d6bec083bd30cd226d (patch)
tree28a5a645ef7bee0ab3956608e2c953b8a63df32d /chrome/browser/importer
parentf9b82d8872f0659ca05bedc17ab14fb0898cc2ba (diff)
downloadchromium_src-7a89f55023d63bb8d2ffb8d6bec083bd30cd226d.zip
chromium_src-7a89f55023d63bb8d2ffb8d6bec083bd30cd226d.tar.gz
chromium_src-7a89f55023d63bb8d2ffb8d6bec083bd30cd226d.tar.bz2
Disable part of the Importer unit test because it fails
on windows sp3 (clean machine). See bug 2466. Review URL: http://codereview.chromium.org/3127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2344 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer')
-rw-r--r--chrome/browser/importer/importer_unittest.cc6
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/importer/importer_unittest.cc b/chrome/browser/importer/importer_unittest.cc
index e7f097e..3d39db1 100644
--- a/chrome/browser/importer/importer_unittest.cc
+++ b/chrome/browser/importer/importer_unittest.cc
@@ -145,10 +145,12 @@ class TestObserver : public ProfileWriter,
MessageLoop::current()->Quit();
EXPECT_EQ(arraysize(kIEBookmarks), bookmark_count_);
EXPECT_EQ(1, history_count_);
+#if 0 // This part of the test is disabled. See bug #2466
if (IsWindowsVista())
EXPECT_EQ(0, password_count_);
else
EXPECT_EQ(1, password_count_);
+#endif
}
virtual bool BookmarkModelIsLoaded() const {
@@ -304,6 +306,7 @@ TEST_F(ImporterTest, IEImporter) {
// Sets up dummy password data.
HRESULT res;
+ #if 0 // This part of the test is disabled. See bug #2466
CComPtr<IPStore> pstore;
HMODULE pstorec_dll;
GUID type = IEImporter::kUnittestGUID;
@@ -324,6 +327,7 @@ TEST_F(ImporterTest, IEImporter) {
pstore->CreateSubtype(0, &type, &subtype, &type_info, NULL, 0);
WritePStore(pstore, &type, &subtype);
}
+#endif
// Sets up a special history link.
CComPtr<IUrlHistoryStg2> url_history_stg2;
@@ -351,12 +355,14 @@ TEST_F(ImporterTest, IEImporter) {
// Cleans up.
url_history_stg2->DeleteUrl(kIEIdentifyUrl, 0);
url_history_stg2.Release();
+#if 0 // This part of the test is disabled. See bug #2466
if (!IsWindowsVista()) {
ClearPStoreType(pstore, &type, &subtype);
// Releases it befor unload the dll.
pstore.Release();
FreeLibrary(pstorec_dll);
}
+#endif
}
TEST_F(ImporterTest, IE7Importer) {