diff options
| author | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 23:24:30 +0000 |
|---|---|---|
| committer | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 23:24:30 +0000 |
| commit | ffe13e5d1339ece50ed25a81bb433d8fb4153b31 (patch) | |
| tree | 76a2bb7d0df24dbb7a1ac2c394a76c2a9ac1b898 /chrome/browser/instant | |
| parent | 3e03e9da055dbd96a59a7f05f0a2b78b8efbd72c (diff) | |
| download | chromium_src-ffe13e5d1339ece50ed25a81bb433d8fb4153b31.zip chromium_src-ffe13e5d1339ece50ed25a81bb433d8fb4153b31.tar.gz chromium_src-ffe13e5d1339ece50ed25a81bb433d8fb4153b31.tar.bz2 | |
Place field trial name at the end (as a suffix).
For consistency in how histograms are usually named.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8015016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102613 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/instant')
| -rw-r--r-- | chrome/browser/instant/instant_controller.cc | 7 | ||||
| -rw-r--r-- | chrome/browser/instant/instant_field_trial.cc | 12 |
2 files changed, 8 insertions, 11 deletions
diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc index 695a796..5dadb5d 100644 --- a/chrome/browser/instant/instant_controller.cc +++ b/chrome/browser/instant/instant_controller.cc @@ -156,11 +156,8 @@ void InstantController::Disable(Profile* profile) { delta.InMinutes(), 1, 60 * 24 * 10, 50); } - if (InstantFieldTrial::IsExperimentGroup(profile)) { - UMA_HISTOGRAM_COUNTS( - "Instant.FieldTrialOptOut." + InstantFieldTrial::GetGroupName(profile), - 1); - } + UMA_HISTOGRAM_COUNTS( + "Instant.OptOut" + InstantFieldTrial::GetGroupName(profile), 1); service->SetBoolean(prefs::kInstantEnabledOnce, true); service->SetBoolean(prefs::kInstantEnabled, false); diff --git a/chrome/browser/instant/instant_field_trial.cc b/chrome/browser/instant/instant_field_trial.cc index 7cbf61e..dc68ac9 100644 --- a/chrome/browser/instant/instant_field_trial.cc +++ b/chrome/browser/instant/instant_field_trial.cc @@ -74,14 +74,14 @@ bool InstantFieldTrial::IsExperimentGroup(Profile* profile) { // static std::string InstantFieldTrial::GetGroupName(Profile* profile) { switch (GetGroup(profile)) { - case INACTIVE: return "InstantInactive"; - case CONTROL1: return "InstantControl1"; - case CONTROL2: return "InstantControl2"; - case EXPERIMENT1: return "InstantExperiment1"; - case EXPERIMENT2: return "InstantExperiment2"; + case INACTIVE: return std::string(); + case CONTROL1: return "_InstantControl1"; + case CONTROL2: return "_InstantControl2"; + case EXPERIMENT1: return "_InstantExperiment1"; + case EXPERIMENT2: return "_InstantExperiment2"; } NOTREACHED(); - return "InstantUnknown"; + return std::string(); } // static |