diff options
| author | alekseys@chromium.org <alekseys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-16 22:33:03 +0000 |
|---|---|---|
| committer | alekseys@chromium.org <alekseys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-16 22:33:03 +0000 |
| commit | e2356245e357455e99aade6a0800032b115c1b53 (patch) | |
| tree | dcd58e1a53d918716650531111141d266d6aea9b /chrome/browser/instant | |
| parent | 880a6d5e6933a40338c06fcc5d9fd7ae5e654a4a (diff) | |
| download | chromium_src-e2356245e357455e99aade6a0800032b115c1b53.zip chromium_src-e2356245e357455e99aade6a0800032b115c1b53.tar.gz chromium_src-e2356245e357455e99aade6a0800032b115c1b53.tar.bz2 | |
Handle resize corner layout entirely in the BrowserView (views) or BrowserWindow* (Mac)
and extend RenderViewHost with a concept of reserved contents rect, a place to show extra stuff,
such as Sidebar's mini tab UI.
sidebar UI implementation warranted this change (mini tabs UI and resize corner area for sidebar
contents).
TabContentsDelegate::GetRootWindowResizerRect() is no more, reserved contents area is now cached
in RenderWidgetHostView and updated upon view resize.
Views: BrowserView is responsible for the actual layout and reserved contents area update.
Mac: TabContentsController now manages all TabContents views in the main browser window to solve
two problems, first to prevent contents flickering during tab change not only for the page,
but for the sidebar and devtools contents too and, second, to monitor contents view frame changes
and update reserved contents area accordingly.
BUG=51084
TEST=All tests should pass, this is a refactoring CL.
Review URL: http://codereview.chromium.org/3547008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66332 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/instant')
| -rw-r--r-- | chrome/browser/instant/instant_loader.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc index 0f877c6..e0ce7ec 100644 --- a/chrome/browser/instant/instant_loader.cc +++ b/chrome/browser/instant/instant_loader.cc @@ -237,9 +237,6 @@ class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate { virtual bool IsApplication() const { return false; } virtual void ConvertContentsToApplication(TabContents* source) {} virtual bool CanReloadContents(TabContents* source) const { return true; } - virtual gfx::Rect GetRootWindowResizerRect() const { - return gfx::Rect(); - } virtual void ShowHtmlDialog(HtmlDialogUIDelegate* delegate, gfx::NativeWindow parent_window) {} virtual void BeforeUnloadFired(TabContents* tab, |