Profiles: Really fix refcounted services.

Previous attempts to share code between ProfileKeyedServiceFactory and RefcountedProfileKeyedServiceFactory were ill advised. The core logic code must maintain refcounted data in a scoped_refptr<> for the entire lifecycle, across interface and implementation, preventing any real abstraction here.

This removes the common ProfileKeyedBase and splits the two worlds entirely in two. This has quite a bit of exact code with different types now.

Fallout from this is far reaching:

- Since there isn't one common heiarchy, now the testing methods either return ProfileKeyedServices or scoped_refptr<RefcountedProfileKeyedService>s. This is a lot of change.

- Many consumers handled the refcounted ptrs as raw pointers, which probably isn't a good idea.

- There is now a bunch of code duplication.

BUG=118196,77155
R=mirandac,tim
TBR=jhawkins,sky,scottbyer

Review URL: http://codereview.chromium.org/9703038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127104 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 1 deletions

diff --git a/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
index e6532ef..2743a28 100644
--- a/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
+++ b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
@@ -25,7 +25,7 @@ class MockWebIntentsRegistry : public WebIntentsRegistry {
                void(const webkit_glue::WebIntentServiceData&));
 };
 
-ProfileKeyedBase* BuildMockWebIntentsRegistry(Profile* profile) {
+ProfileKeyedService* BuildMockWebIntentsRegistry(Profile* profile) {
   return new MockWebIntentsRegistry;
 }