diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-15 03:09:12 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-15 03:09:12 +0000 |
| commit | 71197430cd0d092bcac91a09f8403d45813af650 (patch) | |
| tree | 60c553bd54d3d43f2011a57e0aa8d5f79ecaac60 /chrome/browser/io_thread.cc | |
| parent | 6528f001880d0444f0bff198724f11b4f8761be3 (diff) | |
| download | chromium_src-71197430cd0d092bcac91a09f8403d45813af650.zip chromium_src-71197430cd0d092bcac91a09f8403d45813af650.tar.gz chromium_src-71197430cd0d092bcac91a09f8403d45813af650.tar.bz2 | |
Make the URLFetcher observe IO thread shutdown and auto-cancel its request, if any.
BUG=41547
TEST=none
Review URL: http://codereview.chromium.org/2849003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49761 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/io_thread.cc')
| -rw-r--r-- | chrome/browser/io_thread.cc | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc index 0382ec4d..5dfd284 100644 --- a/chrome/browser/io_thread.cc +++ b/chrome/browser/io_thread.cc @@ -183,17 +183,7 @@ void IOThread::CleanUp() { delete globals_; globals_ = NULL; - // URLFetcher and URLRequest instances must NOT outlive the IO thread. - // - // Strictly speaking, URLFetcher's CheckForLeaks() should be done on the - // UI thread. However, since there _shouldn't_ be any instances left - // at this point, it shouldn't be a race. - // - // We check URLFetcher first, since if it has leaked then an associated - // URLRequest will also have leaked. However it is more useful to - // crash showing the callstack of URLFetcher's allocation than its - // URLRequest member. - base::LeakTracker<URLFetcher>::CheckForLeaks(); + // URLRequest instances must NOT outlive the IO thread. base::LeakTracker<URLRequest>::CheckForLeaks(); BrowserProcessSubThread::CleanUp(); |