diff options
author | oshima@google.com <oshima@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-04 00:10:47 +0000 |
---|---|---|
committer | oshima@google.com <oshima@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-04 00:10:47 +0000 |
commit | 2e5597c7a7dad2a5255979752de155358c485ad4 (patch) | |
tree | 13ba82ec946edc07c058ed35cf2999d402914033 /chrome/browser/jankometer.cc | |
parent | 8e1eaf972ae4e682b00a75fe4bfc54b2da2199b3 (diff) | |
download | chromium_src-2e5597c7a7dad2a5255979752de155358c485ad4.zip chromium_src-2e5597c7a7dad2a5255979752de155358c485ad4.tar.gz chromium_src-2e5597c7a7dad2a5255979752de155358c485ad4.tar.bz2 |
Consolidate message observer API for MessagePumpX and MessagePumWin
This is an attempt to simplify the code around message pump observer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8021009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103825 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/jankometer.cc')
-rw-r--r-- | chrome/browser/jankometer.cc | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/chrome/browser/jankometer.cc b/chrome/browser/jankometer.cc index eeb4a18..e9919e5 100644 --- a/chrome/browser/jankometer.cc +++ b/chrome/browser/jankometer.cc @@ -304,9 +304,10 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>, } #if defined(OS_WIN) - virtual void WillProcessMessage(const MSG& msg) { + virtual base::EventStatus WillProcessEvent( + const base::NativeEvent& event) OVERRIDE { if (!helper_.MessageWillBeMeasured()) - return; + return base::EVENT_CONTINUE; // GetMessageTime returns a LONG (signed 32-bit) and GetTickCount returns // a DWORD (unsigned 32-bit). They both wrap around when the time is longer // than they can hold. I'm not sure if GetMessageTime wraps around to 0, @@ -316,17 +317,26 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>, // Therefore, I cast to DWORD so if it wraps to -1 we will correct it. If // it doesn't, then our time delta will be negative if a message happens // to straddle the wraparound point, it will still be OK. - DWORD cur_message_issue_time = static_cast<DWORD>(msg.time); + DWORD cur_message_issue_time = static_cast<DWORD>(event.time); DWORD cur_time = GetTickCount(); base::TimeDelta queueing_time = base::TimeDelta::FromMilliseconds(cur_time - cur_message_issue_time); helper_.StartProcessingTimers(queueing_time); + return base::EVENT_CONTINUE; } - virtual void DidProcessMessage(const MSG& msg) { + virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE { helper_.EndProcessingTimers(); } +#elif defined(TOUCH_UI) || defined(USE_AURA) + virtual base::EventStatus WillProcessEvent( + const base::NativeEvent& event) OVERRIDE { + return base::EVENT_CONTINUE; + } + + virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE { + } #elif defined(TOOLKIT_USES_GTK) virtual void WillProcessEvent(GdkEvent* event) { if (!helper_.MessageWillBeMeasured()) |