summaryrefslogtreecommitdiffstats
path: root/chrome/browser/js_modal_dialog_mac.mm
diff options
context:
space:
mode:
authorviettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-09 17:02:50 +0000
committerviettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-09 17:02:50 +0000
commit7dc8c6baea151a7e803b3781f89e81c5e53ee40e (patch)
tree3f4f72ef5eae82b976657a70f188d21e77bf9cad /chrome/browser/js_modal_dialog_mac.mm
parent7717e6e61a7b681d9ed351339c2850ae13b5ccb3 (diff)
downloadchromium_src-7dc8c6baea151a7e803b3781f89e81c5e53ee40e.zip
chromium_src-7dc8c6baea151a7e803b3781f89e81c5e53ee40e.tar.gz
chromium_src-7dc8c6baea151a7e803b3781f89e81c5e53ee40e.tar.bz2
Mac: reform our shutdown routine.
Make shutdown be more like other platforms. Moreover: - Cancelling quit from an onbeforeunload dialog shouldn't mess up the browser. - Having quit cancelled due to a window pop up on the closure of another window shouldn't break the browser. [With this patch, it will result in the browser being in a quirky state in which the closure of the last browser window will cause a quit. But the browser won't be broken.] BUG=34384,37813,37927 TEST=See bugs. Review URL: http://codereview.chromium.org/1520006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44096 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/js_modal_dialog_mac.mm')
-rw-r--r--chrome/browser/js_modal_dialog_mac.mm6
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/js_modal_dialog_mac.mm b/chrome/browser/js_modal_dialog_mac.mm
index 3bdc9aa..d15e6ad 100644
--- a/chrome/browser/js_modal_dialog_mac.mm
+++ b/chrome/browser/js_modal_dialog_mac.mm
@@ -10,6 +10,7 @@
#include "app/message_box_flags.h"
#import "base/cocoa_protocols_mac.h"
#include "base/sys_string_conversions.h"
+#import "chrome/browser/chrome_browser_application_mac.h"
#include "grit/app_strings.h"
#include "grit/generated_resources.h"
@@ -68,6 +69,11 @@
break;
}
case NSAlertSecondButtonReturn: { // Cancel
+ // If the user wants to stay on this page, stop quitting (if a quit is in
+ // progress).
+ if (bridge->is_before_unload_dialog())
+ chrome_browser_application_mac::CancelTerminate();
+
bridge->OnCancel();
break;
}