diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-06 04:27:05 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-06 04:27:05 +0000 |
| commit | dd5684a027e4a3b2d74cb9eeebfb039171008503 (patch) | |
| tree | b3013ab636f6fd3b86c335dd51f15e57ca35e9c3 /chrome/browser/jsmessage_box_handler.h | |
| parent | 5d244865ed539d1bf8236fbda2b316d20a24231d (diff) | |
| download | chromium_src-dd5684a027e4a3b2d74cb9eeebfb039171008503.zip chromium_src-dd5684a027e4a3b2d74cb9eeebfb039171008503.tar.gz chromium_src-dd5684a027e4a3b2d74cb9eeebfb039171008503.tar.bz2 | |
Change all classes that use the NOTIFY_NAV_ENTRY_COMMITTED notification to use the notification registrar. This is a speculative fix for a crash I happened to catch in a debugger where the pointer was invalid when dispatching this notifcation. It could be one of these consumers is leaking it's registered observer (the TabContents is the most suspicious one).
Review URL: http://codereview.chromium.org/16519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7581 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/jsmessage_box_handler.h')
| -rw-r--r-- | chrome/browser/jsmessage_box_handler.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/chrome/browser/jsmessage_box_handler.h b/chrome/browser/jsmessage_box_handler.h index 6873605..920d03d 100644 --- a/chrome/browser/jsmessage_box_handler.h +++ b/chrome/browser/jsmessage_box_handler.h @@ -2,12 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H__ -#define CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H__ +#ifndef CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H_ +#define CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H_ #include "chrome/common/ipc_message.h" #include "chrome/views/app_modal_dialog_delegate.h" #include "chrome/common/notification_service.h" +#include "chrome/common/notification_registrar.h" class MessageBoxView; class WebContents; @@ -64,6 +65,8 @@ class JavascriptMessageBoxHandler const NotificationSource& source, const NotificationDetails& details); + NotificationRegistrar registrar_; + // The message box view whose commands we handle. MessageBoxView* message_box_view_; @@ -83,5 +86,4 @@ class JavascriptMessageBoxHandler DISALLOW_EVIL_CONSTRUCTORS(JavascriptMessageBoxHandler); }; -#endif // CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H__ - +#endif // CHROME_BROWSER_JSMESSAGE_BOX_HANDLER_H_ |