diff options
| author | mukai <mukai@chromium.org> | 2014-10-16 18:10:48 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-17 01:11:05 +0000 |
| commit | 523714fe51f36b7b850722e760619119e479d081 (patch) | |
| tree | 207b521f8e2d07ad23ca4a8060c4b81f9f06531f /chrome/browser/local_discovery | |
| parent | 2d6e305a6dbed90249c9be9225bb1b98a793f25a (diff) | |
| download | chromium_src-523714fe51f36b7b850722e760619119e479d081.zip chromium_src-523714fe51f36b7b850722e760619119e479d081.tar.gz chromium_src-523714fe51f36b7b850722e760619119e479d081.tar.bz2 | |
Remove unnecessary image downloading handler of notifications.
The image_url, small_image_url, and the button urls are never
set in the current code base. Removing these URLs also means
removing the ImageDownloads of MessageCenterNotificationManager,
and also means removing unnecessary methods of NotificationDelegate.
I think NotificationDelegate::id() can be removed and then
we can completely remove ::NotificationDelegate class for now,
but that would be done in another CL.
This CL depends on https://codereview.chromium.org/554213003/
BUG=None
R=dewittj@chromium.org, peter@chromium.org
TBR=atwilson@chromium.org, vitalybuka@chromium.org, tapted@chromium.org, oshima@chromium.org
TEST=no functional changes, build succeeds
Review URL: https://codereview.chromium.org/580243004
Cr-Commit-Position: refs/heads/master@{#300032}
Diffstat (limited to 'chrome/browser/local_discovery')
| -rw-r--r-- | chrome/browser/local_discovery/privet_notifications.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/local_discovery/privet_notifications.h | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/local_discovery/privet_notifications.cc b/chrome/browser/local_discovery/privet_notifications.cc index 3ec7fdb..cc7d65b 100644 --- a/chrome/browser/local_discovery/privet_notifications.cc +++ b/chrome/browser/local_discovery/privet_notifications.cc @@ -370,10 +370,6 @@ std::string PrivetNotificationDelegate::id() const { return kPrivetNotificationID; } -content::WebContents* PrivetNotificationDelegate::GetWebContents() const { - return NULL; -} - void PrivetNotificationDelegate::Display() { } diff --git a/chrome/browser/local_discovery/privet_notifications.h b/chrome/browser/local_discovery/privet_notifications.h index 646eff3..aae7cdd 100644 --- a/chrome/browser/local_discovery/privet_notifications.h +++ b/chrome/browser/local_discovery/privet_notifications.h @@ -133,7 +133,6 @@ class PrivetNotificationDelegate : public NotificationDelegate { // NotificationDelegate implementation. virtual std::string id() const override; - virtual content::WebContents* GetWebContents() const override; virtual void Display() override; virtual void Error() override; virtual void Close(bool by_user) override; |