diff options
author | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-27 19:27:14 +0000 |
---|---|---|
committer | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-27 19:27:14 +0000 |
commit | e1031593bebcddda82503d92b4a7a79b7f2d36e5 (patch) | |
tree | aa257d3e4e45e70d848b7393a597c79dd1ee0306 /chrome/browser/locale_tests_uitest.cc | |
parent | 2a45f099a7c7fc5656aa5ec703a931683a1190c5 (diff) | |
download | chromium_src-e1031593bebcddda82503d92b4a7a79b7f2d36e5.zip chromium_src-e1031593bebcddda82503d92b4a7a79b7f2d36e5.tar.gz chromium_src-e1031593bebcddda82503d92b4a7a79b7f2d36e5.tar.bz2 |
Change locale uitests so that the language environment will be restored even if an assertion occurs in SetUp().
BUG=59337
TEST=Verify locale uitests stay green.
Review URL: http://codereview.chromium.org/4021004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/locale_tests_uitest.cc')
-rw-r--r-- | chrome/browser/locale_tests_uitest.cc | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/chrome/browser/locale_tests_uitest.cc b/chrome/browser/locale_tests_uitest.cc index 85a9510..ea171a8 100644 --- a/chrome/browser/locale_tests_uitest.cc +++ b/chrome/browser/locale_tests_uitest.cc @@ -12,8 +12,7 @@ class LocaleTestsBase : public UITest { LocaleTestsBase() : UITest(), old_lc_all_(NULL) { } - protected: - void RestoreLcAllEnvironment() { + virtual void TearDown() { #if defined(OS_LINUX) scoped_ptr<base::Environment> env(base::Environment::Create()); if (old_lc_all_) { @@ -22,8 +21,10 @@ class LocaleTestsBase : public UITest { env->UnSetVar("LC_ALL"); } #endif - }; + UITest::TearDown(); + } + protected: const char* old_lc_all_; }; @@ -66,15 +67,12 @@ class LocaleTestsZhTw : public LocaleTestsBase { TEST_F(LocaleTestsDa, TestStart) { // Just making sure we can start/shutdown cleanly. - RestoreLcAllEnvironment(); } TEST_F(LocaleTestsHe, TestStart) { // Just making sure we can start/shutdown cleanly. - RestoreLcAllEnvironment(); } TEST_F(LocaleTestsZhTw, TestStart) { // Just making sure we can start/shutdown cleanly. - RestoreLcAllEnvironment(); } |