diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-22 21:25:31 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-22 21:25:31 +0000 |
| commit | f145b5a019b9a082ff0ce94ba94342bbd73f88b2 (patch) | |
| tree | 473b76aef80b498f0d29729e516e67eee24905e8 /chrome/browser/login_prompt.h | |
| parent | 699c1e725012084d66b8a77781cc8cb202505932 (diff) | |
| download | chromium_src-f145b5a019b9a082ff0ce94ba94342bbd73f88b2.zip chromium_src-f145b5a019b9a082ff0ce94ba94342bbd73f88b2.tar.gz chromium_src-f145b5a019b9a082ff0ce94ba94342bbd73f88b2.tar.bz2 | |
Add a TODO comment for later when I have more time. (hahaha)
Review URL: http://codereview.chromium.org/144005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18960 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/login_prompt.h')
| -rw-r--r-- | chrome/browser/login_prompt.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/login_prompt.h b/chrome/browser/login_prompt.h index 5027409..6279c7a 100644 --- a/chrome/browser/login_prompt.h +++ b/chrome/browser/login_prompt.h @@ -28,6 +28,12 @@ class URLRequest; // the URLRequest that needs it. Used by the automation proxy for testing. // These functions should be (and are, in LoginHandlerImpl) implemented in // a thread safe manner. +// +// TODO(erg): Refactor the common code from all LoginHandler subclasses into a +// common controller class. All the methods below have the same copy/pasted +// implementation. This is more difficult then it should be because all these +// subclasses are also base::RefCountedThreadSafe<> and I'm not sure how to get +// ownership correct. http://crbug.com/14909 class LoginHandler { public: // Builds the platform specific LoginHandler. Used from within |