diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-02 19:20:13 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-02 19:20:13 +0000 |
| commit | 1db06851c0de18c6049a88379750f5651cc92a75 (patch) | |
| tree | b73c3fc45a07f77ab55fc3de83c4e035b5ba2387 /chrome/browser/message_box_handler.cc | |
| parent | 7fef9717afc4570883a9207fb8ea70f295685488 (diff) | |
| download | chromium_src-1db06851c0de18c6049a88379750f5651cc92a75.zip chromium_src-1db06851c0de18c6049a88379750f5651cc92a75.tar.gz chromium_src-1db06851c0de18c6049a88379750f5651cc92a75.tar.bz2 | |
Add a Delegate to JavaScriptAppModalDialog.
Done a couples of things here:
- Renamed JavaScriptMessageBoxClient to JavaScriptMessageBoxDelegate (since this is a common pattern in chrome and helps the reader to find out where the message box goes).
- Moved that class into js_modal_dialog.h file.
- Deleted jsmessage_box_client.h
It is a following to http://codereview.chromium.org/3384036.
BUG=54988
TEST=trybots
Review URL: http://codereview.chromium.org/3576003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61309 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/message_box_handler.cc')
| -rw-r--r-- | chrome/browser/message_box_handler.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/message_box_handler.cc b/chrome/browser/message_box_handler.cc index 7389cc7..1f5831a 100644 --- a/chrome/browser/message_box_handler.cc +++ b/chrome/browser/message_box_handler.cc @@ -62,7 +62,7 @@ static std::wstring GetTitle(Profile* profile, } void RunJavascriptMessageBox(Profile* profile, - JavaScriptMessageBoxClient* client, + JavaScriptAppModalDialogDelegate* delegate, const GURL& frame_url, int dialog_flags, const std::wstring& message_text, @@ -72,7 +72,7 @@ void RunJavascriptMessageBox(Profile* profile, bool is_alert = dialog_flags == MessageBoxFlags::kIsJavascriptAlert; std::wstring title = GetTitle(profile, is_alert, frame_url); Singleton<AppModalDialogQueue>()->AddDialog(new JavaScriptAppModalDialog( - client, title, dialog_flags, message_text, default_prompt_text, + delegate, title, dialog_flags, message_text, default_prompt_text, display_suppress_checkbox, false, reply_msg)); } |