diff options
| author | mad@google.com <mad@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-27 16:23:14 +0000 |
|---|---|---|
| committer | mad@google.com <mad@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-27 16:23:14 +0000 |
| commit | ae393ec70a52e34e9f17536faf1889b69d767b3a (patch) | |
| tree | 3ae0d5993ce400117f79885ebdda8b539f82637e /chrome/browser/metrics | |
| parent | 3530cd9023fed0204e7df17b11f121d89ca6303a (diff) | |
| download | chromium_src-ae393ec70a52e34e9f17536faf1889b69d767b3a.zip chromium_src-ae393ec70a52e34e9f17536faf1889b69d767b3a.tar.gz chromium_src-ae393ec70a52e34e9f17536faf1889b69d767b3a.tar.bz2 | |
Cleanup some unncessary dependencies on libxml.
As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper.
BUG=0
TEST=None
Review URL: http://codereview.chromium.org/2753010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50952 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics')
| -rw-r--r-- | chrome/browser/metrics/metrics_service.cc | 3 | ||||
| -rw-r--r-- | chrome/browser/metrics/metrics_service.h | 6 |
2 files changed, 8 insertions, 1 deletions
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc index 21c1789..c158226 100644 --- a/chrome/browser/metrics/metrics_service.cc +++ b/chrome/browser/metrics/metrics_service.cc @@ -187,6 +187,7 @@ #include "chrome/common/pref_names.h" #include "chrome/common/render_messages.h" #include "webkit/glue/plugins/plugin_list.h" +#include "libxml/xmlwriter.h" #if !defined(OS_WIN) #include "base/rand_util.h" @@ -700,7 +701,7 @@ void MetricsService::InitializeMetricsState() { // Initialize uptime counters. int64 startup_uptime = MetricsLog::GetIncrementalUptime(pref); - DCHECK(0 == startup_uptime); + DCHECK_EQ(0, startup_uptime); // For backwards compatibility, leave this intact in case Omaha is checking // them. prefs::kStabilityLastTimestampSec may also be useless now. // TODO(jar): Delete these if they have no uses. diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h index 016640d..de6b6ba 100644 --- a/chrome/browser/metrics/metrics_service.h +++ b/chrome/browser/metrics/metrics_service.h @@ -36,6 +36,12 @@ class HistogramSynchronizer; class PrefService; class TemplateURLModel; +// Forward declaration of the xmlNode to avoid having tons of gyp files +// needing to depend on the libxml third party lib. +struct _xmlNode; +typedef struct _xmlNode xmlNode; +typedef xmlNode* xmlNodePtr; + // This is used to quickly log stats from child process related notifications in // MetricsService::child_stats_buffer_. The buffer's contents are transferred // out when Local State is periodically saved. The information is then |