diff options
author | mpcomplete@google.com <mpcomplete@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 00:50:53 +0000 |
---|---|---|
committer | mpcomplete@google.com <mpcomplete@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 00:50:53 +0000 |
commit | 6ba2ec2e23f79f1882263a4fb1cd12efc0651e88 (patch) | |
tree | efbcef6f1224e165fee0ebd987dd0fc567d13fe4 /chrome/browser/metrics | |
parent | 10235beedc6fbfdb50453a7568e3279c25714624 (diff) | |
download | chromium_src-6ba2ec2e23f79f1882263a4fb1cd12efc0651e88.zip chromium_src-6ba2ec2e23f79f1882263a4fb1cd12efc0651e88.tar.gz chromium_src-6ba2ec2e23f79f1882263a4fb1cd12efc0651e88.tar.bz2 |
Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close the
RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED,
but the latter is not always sent since the process could get reused. It also
takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean
Details indicating whether the process crashed (true) or just exited (false).
Review URL: http://codereview.chromium.org/100277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics')
-rw-r--r-- | chrome/browser/metrics/metrics_service.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc index c54b36e..21adc52 100644 --- a/chrome/browser/metrics/metrics_service.cc +++ b/chrome/browser/metrics/metrics_service.cc @@ -505,8 +505,9 @@ void MetricsService::Observe(NotificationType type, LogLoadStarted(); break; - case NotificationType::RENDERER_PROCESS_CRASHED: - LogRendererCrash(); + case NotificationType::RENDERER_PROCESS_CLOSED: + if (*Details<bool>(details).ptr()) + LogRendererCrash(); break; case NotificationType::RENDERER_PROCESS_HANG: @@ -796,7 +797,7 @@ void MetricsService::ListenerRegistration(bool start_listening) { AddOrRemoveObserver(this, NotificationType::LOAD_STOP, start_listening); AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_IN_SBOX, start_listening); - AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_CRASHED, + AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_CLOSED, start_listening); AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_HANG, start_listening); |