diff options
| author | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-18 21:54:39 +0000 |
|---|---|---|
| committer | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-18 21:54:39 +0000 |
| commit | ee2a79e9ed2339cb9548c43ae471b05d6418f2a7 (patch) | |
| tree | 09a7e15a9dfe21277b8893f7fdb9ee6e71b973f2 /chrome/browser/metrics | |
| parent | 89fb65a6f0f1b6981c26c9b9d05a02332f6ec6d7 (diff) | |
| download | chromium_src-ee2a79e9ed2339cb9548c43ae471b05d6418f2a7.zip chromium_src-ee2a79e9ed2339cb9548c43ae471b05d6418f2a7.tar.gz chromium_src-ee2a79e9ed2339cb9548c43ae471b05d6418f2a7.tar.bz2 | |
o Update the mapping of action hashes to their appropriate identifiers.
o Update user_metrics.h to be more explicit about how to add metrics.
o Update the some BookmarkBar metrics to fit on one line as is required by the script.
BUG=59606
TEST=none
Review URL: http://codereview.chromium.org/3815011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62982 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics')
| -rw-r--r-- | chrome/browser/metrics/user_metrics.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/metrics/user_metrics.h b/chrome/browser/metrics/user_metrics.h index 8fcca7a..e9addb6 100644 --- a/chrome/browser/metrics/user_metrics.h +++ b/chrome/browser/metrics/user_metrics.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -23,7 +23,6 @@ struct UserMetricsAction { }; - class UserMetrics { public: // Record that the user performed an action. @@ -34,8 +33,13 @@ class UserMetrics { // interacting with the browser. // WARNING: Call this function exactly like this: // UserMetrics::RecordAction(UserMetricsAction("foo bar")); + // (all on one line and with the metric string literal [no variables]) // because otherwise our processing scripts won't pick up on new actions. // + // Once a new recorded action is added, run chrome/tools/extract_actions.py + // to generate a new mapping of [action hashes -> metric names] and send it + // out for review to be updated. + // // For more complicated situations (like when there are many different // possible actions), see RecordComputedAction. // |