diff options
author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-24 01:18:57 +0000 |
---|---|---|
committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-24 01:18:57 +0000 |
commit | b0c6e5d820fb2da79f9f36e449f66caec1389bfd (patch) | |
tree | a4fd0622c4a0b58f01fd88811bca411f4c048137 /chrome/browser/modal_html_dialog_delegate.cc | |
parent | 991fee4eda6561e606f780030af1bfbaba732a10 (diff) | |
download | chromium_src-b0c6e5d820fb2da79f9f36e449f66caec1389bfd.zip chromium_src-b0c6e5d820fb2da79f9f36e449f66caec1389bfd.tar.gz chromium_src-b0c6e5d820fb2da79f9f36e449f66caec1389bfd.tar.bz2 |
HtmlDialogContentsDelegate should not subclass views::WindowDelegate, for portability reasons (views isn't used on Mac or Linux).
Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead.
TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up.
Review URL: http://codereview.chromium.org/27074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10236 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/modal_html_dialog_delegate.cc')
-rw-r--r-- | chrome/browser/modal_html_dialog_delegate.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/modal_html_dialog_delegate.cc b/chrome/browser/modal_html_dialog_delegate.cc index fa8549c..5148c38 100644 --- a/chrome/browser/modal_html_dialog_delegate.cc +++ b/chrome/browser/modal_html_dialog_delegate.cc @@ -37,7 +37,7 @@ void ModalHtmlDialogDelegate::Observe(NotificationType type, RemoveObserver(); } -bool ModalHtmlDialogDelegate::IsModal() const { +bool ModalHtmlDialogDelegate::IsDialogModal() const { return true; } |