summaryrefslogtreecommitdiffstats
path: root/chrome/browser/navigation_controller_unittest.cc
diff options
context:
space:
mode:
authorbrettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-07 23:57:40 +0000
committerbrettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-07 23:57:40 +0000
commite83f16853d443dd0556b7e8c42f1f6013581715d (patch)
tree58a34a6602aa351ae1d35c2ab5117a0ffd01089a /chrome/browser/navigation_controller_unittest.cc
parentf80ea89e0e951089b9f08ea40c2c2b528f3df66f (diff)
downloadchromium_src-e83f16853d443dd0556b7e8c42f1f6013581715d.zip
chromium_src-e83f16853d443dd0556b7e8c42f1f6013581715d.tar.gz
chromium_src-e83f16853d443dd0556b7e8c42f1f6013581715d.tar.bz2
Fix SSL state in the URL bar being incorrect. Going to an EV site like https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on.
This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar. BUG=1359547 TEST=see repro steps in bug Review URL: http://codereview.chromium.org/436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1831 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/navigation_controller_unittest.cc')
-rw-r--r--chrome/browser/navigation_controller_unittest.cc4
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/navigation_controller_unittest.cc b/chrome/browser/navigation_controller_unittest.cc
index bea08ac7..f9f22e9 100644
--- a/chrome/browser/navigation_controller_unittest.cc
+++ b/chrome/browser/navigation_controller_unittest.cc
@@ -375,7 +375,9 @@ TEST_F(NavigationControllerTest, LoadURL) {
}
// Tests what happens when the same page is loaded again. Should not create a
-// new session history entry.
+// new session history entry. This is what happens when you press enter in the
+// URL bar to reload: a pending entry is created and then it is discarded when
+// the load commits (because WebCore didn't actually make a new entry).
TEST_F(NavigationControllerTest, LoadURL_SamePage) {
TestNotificationTracker notifications;
RegisterForAllNavNotifications(&notifications, contents->controller());