diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 23:52:57 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 23:52:57 +0000 |
| commit | 2fb62920c987513f7b5f041c99be5a8ed09888ec (patch) | |
| tree | 7c0355bb9fb4ecae13aeecc572a8261e94d89436 /chrome/browser/net/connection_tester.h | |
| parent | 24d5cc6bb1328948d7a0658a7fa3acf6de5b91f8 (diff) | |
| download | chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.zip chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.tar.gz chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.tar.bz2 | |
Create a URLRequestContext for PAC fetching.
Originally I was going to create a single "system" URLRequestContext. I realized that was wrong, I need one for proxy script fetching that uses a direct ProxyService. This way, we don't have the circular dependencies for URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(A). Instead, we have URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(special one for proxy).
This also exposes some setters in URLRequestContext that were in ChromeURLRequestContext. I guess this makes URLRequestContext a bit more "dangerous" since it could be mutated during runtime, but really we should probably pass around a const URLRequestContext within the network stack. I've filed http://crbug.com/67597 to track this.
BUG=67232
TEST=none
Review URL: http://codereview.chromium.org/5961005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70116 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net/connection_tester.h')
| -rw-r--r-- | chrome/browser/net/connection_tester.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/net/connection_tester.h b/chrome/browser/net/connection_tester.h index e0a7446..1d206ac 100644 --- a/chrome/browser/net/connection_tester.h +++ b/chrome/browser/net/connection_tester.h @@ -13,7 +13,7 @@ #include "googleurl/src/gurl.h" #include "net/base/completion_callback.h" -class IOThread; +class URLRequestContext; // ConnectionTester runs a suite of tests (also called "experiments"), // to try and discover why loading a particular URL is failing with an error @@ -125,7 +125,8 @@ class ConnectionTester { // Constructs a ConnectionTester that notifies test progress to |delegate|. // |delegate| is owned by the caller, and must remain valid for the lifetime // of ConnectionTester. - ConnectionTester(Delegate* delegate, IOThread* io_thread); + ConnectionTester(Delegate* delegate, + URLRequestContext* proxy_request_context); // Note that destruction cancels any in-progress tests. ~ConnectionTester(); @@ -171,10 +172,9 @@ class ConnectionTester { // of the list is the one currently in progress. ExperimentList remaining_experiments_; - IOThread* io_thread_; + const scoped_refptr<URLRequestContext> proxy_request_context_; DISALLOW_COPY_AND_ASSIGN(ConnectionTester); }; #endif // CHROME_BROWSER_NET_CONNECTION_TESTER_H_ - |