summaryrefslogtreecommitdiffstats
path: root/chrome/browser/net/proxy_service_factory.cc
diff options
context:
space:
mode:
authorjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-17 17:55:35 +0000
committerjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-17 17:55:35 +0000
commit00106e1c05c9dcd01f055f8682e87bc97a09c648 (patch)
tree9fb08a6a44726056dd75607022dbbf31315cb994 /chrome/browser/net/proxy_service_factory.cc
parent92c6608cda88cf297275ba4b964b64f3475abbd6 (diff)
downloadchromium_src-00106e1c05c9dcd01f055f8682e87bc97a09c648.zip
chromium_src-00106e1c05c9dcd01f055f8682e87bc97a09c648.tar.gz
chromium_src-00106e1c05c9dcd01f055f8682e87bc97a09c648.tar.bz2
Revert 85646 - Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol.
This is Windows-only for now, and is disabled by default. Start Chrome with the flag --enable-dhcp-wpad to enable the feature. See discussion in comment on DhcpProxyScriptFetcherFactory for why this needs to be done in a per-platform way rather than cross-platform. The code is factored so that adding other platform implementations will be straight forward. Most of the implementation is stand-alone and extends the ScriptProxyFetcher class hierarchy (and makes its interface slightly more generic). The integration point into existing code is in InitProxyResolver, which previously handled fallback from DNS auto-detect to custom PAC URL and now does fallback from DHCP to DNS to custom PAC URL. BUG=18575 TEST=net_unittests has good coverage for the new and changed code, but manual tests on a network with a PAC URL configured in DHCP are also needed. Review URL: http://codereview.chromium.org/6831025 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/7019015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85648 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net/proxy_service_factory.cc')
-rw-r--r--chrome/browser/net/proxy_service_factory.cc7
1 files changed, 0 insertions, 7 deletions
diff --git a/chrome/browser/net/proxy_service_factory.cc b/chrome/browser/net/proxy_service_factory.cc
index cf97923..ba1cb9a 100644
--- a/chrome/browser/net/proxy_service_factory.cc
+++ b/chrome/browser/net/proxy_service_factory.cc
@@ -12,7 +12,6 @@
#include "chrome/common/chrome_switches.h"
#include "content/browser/browser_thread.h"
#include "net/base/net_log.h"
-#include "net/proxy/dhcp_proxy_script_fetcher_factory.h"
#include "net/proxy/proxy_config_service.h"
#include "net/proxy/proxy_script_fetcher_impl.h"
#include "net/proxy/proxy_service.h"
@@ -85,16 +84,10 @@ net::ProxyService* ProxyServiceFactory::CreateProxyService(
net::ProxyService* proxy_service;
if (use_v8) {
- net::DhcpProxyScriptFetcherFactory dhcp_factory;
- if (command_line.HasSwitch(switches::kEnableDhcpWpad)) {
- dhcp_factory.set_enabled(true);
- }
-
proxy_service = net::ProxyService::CreateUsingV8ProxyResolver(
proxy_config_service,
num_pac_threads,
new net::ProxyScriptFetcherImpl(context),
- dhcp_factory.Create(context),
context->host_resolver(),
net_log,
context->network_delegate());