summaryrefslogtreecommitdiffstats
path: root/chrome/browser/net/url_fetcher_unittest.cc
diff options
context:
space:
mode:
authordkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-14 23:14:35 +0000
committerdkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-14 23:14:35 +0000
commit518fdec3a07a94dc45d6e7e4ad1b529747dc03d3 (patch)
treefb2b17479a907a8960a8dc865630fe7272d041fc /chrome/browser/net/url_fetcher_unittest.cc
parent5e997eacfb2234633831d06c91859ee76af44468 (diff)
downloadchromium_src-518fdec3a07a94dc45d6e7e4ad1b529747dc03d3.zip
chromium_src-518fdec3a07a94dc45d6e7e4ad1b529747dc03d3.tar.gz
chromium_src-518fdec3a07a94dc45d6e7e4ad1b529747dc03d3.tar.bz2
Reverting r9823 (http://codereview.chromium.org/16207) because
1) the Interactive Tests (dbg) buildbot needs the SSL cert installed 2) the same buildbot showed a refcounting problem, e.g. FATAL:ref_counted.cc(22)] Check failed: in_dtor_. RefCounted object deleted without calling Release() c:\b\slave\chromium-dbg-builder\build\src\chrome\browser\views\find_bar_win_interactive_uitest.cc(57): error: Value of: NULL != server.get() Actual: false Expected: true [ FAILED ] FindInPageTest.CrashEscHandlers (2109 ms) 3) the Webkit Linux buildbot failed four tests redirect302-frames.html cross-frame-access-protocol-explicit-domain.html cross-frame-access-protocol.html origin-header-for-https.html I'm leaving the tcp_pinger files in for the moment, they shouldn't hurt anything. Review URL: http://codereview.chromium.org/23028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9827 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net/url_fetcher_unittest.cc')
-rw-r--r--chrome/browser/net/url_fetcher_unittest.cc11
1 files changed, 10 insertions, 1 deletions
diff --git a/chrome/browser/net/url_fetcher_unittest.cc b/chrome/browser/net/url_fetcher_unittest.cc
index a9f0c0f17..03b40d7 100644
--- a/chrome/browser/net/url_fetcher_unittest.cc
+++ b/chrome/browser/net/url_fetcher_unittest.cc
@@ -104,6 +104,10 @@ class URLFetcherBadHTTPSTest : public URLFetcherTest {
const ResponseCookies& cookies,
const std::string& data);
+ protected:
+ FilePath GetExpiredCertPath();
+ SSLTestUtil util_;
+
private:
FilePath cert_dir_;
};
@@ -295,6 +299,10 @@ void URLFetcherBadHTTPSTest::OnURLFetchComplete(
io_loop_.Quit();
}
+FilePath URLFetcherBadHTTPSTest::GetExpiredCertPath() {
+ return cert_dir_.AppendASCII("expired_cert.pem");
+}
+
void URLFetcherCancelTest::CreateFetcher(const GURL& url) {
fetcher_ = new URLFetcher(url, URLFetcher::GET, this);
fetcher_->set_request_context(
@@ -427,7 +435,8 @@ TEST_F(URLFetcherBadHTTPSTest, BadHTTPSTest) {
TEST_F(URLFetcherBadHTTPSTest, DISABLED_BadHTTPSTest) {
#endif
scoped_refptr<HTTPSTestServer> server =
- HTTPSTestServer::CreateExpiredServer(kDocRoot);
+ HTTPSTestServer::CreateServer(util_.kHostName, util_.kBadHTTPSPort,
+ kDocRoot, util_.GetExpiredCertPath().ToWStringHack());
ASSERT_TRUE(NULL != server.get());
CreateFetcher(GURL(server->TestServerPage("defaultresponse")));