diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-10 04:52:20 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-10 04:52:20 +0000 |
commit | 945a25941ed4de145a5041cccbe5908c92aa0c3b (patch) | |
tree | d2682973318368507b05183ef78fdc7e3c205b22 /chrome/browser/net | |
parent | bd8127e04c9cb0ec1a74408b6a10dc8d19f937e6 (diff) | |
download | chromium_src-945a25941ed4de145a5041cccbe5908c92aa0c3b.zip chromium_src-945a25941ed4de145a5041cccbe5908c92aa0c3b.tar.gz chromium_src-945a25941ed4de145a5041cccbe5908c92aa0c3b.tar.bz2 |
Test change to fix a leak. Will revert after getting in a run on ChromiumOS valgrind bots.
Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP."
Review URL: http://codereview.chromium.org/3681003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62105 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net')
-rw-r--r-- | chrome/browser/net/chrome_url_request_context.cc | 16 | ||||
-rw-r--r-- | chrome/browser/net/chrome_url_request_context.h | 1 |
2 files changed, 10 insertions, 7 deletions
diff --git a/chrome/browser/net/chrome_url_request_context.cc b/chrome/browser/net/chrome_url_request_context.cc index 9f053f3..28f7621 100644 --- a/chrome/browser/net/chrome_url_request_context.cc +++ b/chrome/browser/net/chrome_url_request_context.cc @@ -314,11 +314,6 @@ ChromeURLRequestContext* FactoryForOriginal::Create() { appcache_service_->set_request_context(context); -#if defined(USE_NSS) - // TODO(ukai): find a better way to set the URLRequestContext for OCSP. - net::SetURLRequestContextForOCSP(context); -#endif - context->set_net_log(io_thread_globals->net_log.get()); return context; } @@ -559,6 +554,14 @@ URLRequestContext* ChromeURLRequestContextGetter::GetURLRequestContext() { if (!url_request_context_) { DCHECK(factory_.get()); url_request_context_ = factory_->Create(); + if (is_main()) { + url_request_context_->set_is_main(true); +#if defined(USE_NSS) + // TODO(ukai): find a better way to set the URLRequestContext for OCSP. + net::SetURLRequestContextForOCSP(url_request_context_); +#endif + } + factory_.reset(); } @@ -756,7 +759,8 @@ ChromeURLRequestContext::~ChromeURLRequestContext() { } #if defined(USE_NSS) - if (this == net::GetURLRequestContextForOCSP()) { + if (is_main()) { + DCHECK_EQ(this, net::GetURLRequestContextForOCSP()); // We are releasing the URLRequestContext used by OCSP handlers. net::SetURLRequestContextForOCSP(NULL); } diff --git a/chrome/browser/net/chrome_url_request_context.h b/chrome/browser/net/chrome_url_request_context.h index 183ad4a..a580282 100644 --- a/chrome/browser/net/chrome_url_request_context.h +++ b/chrome/browser/net/chrome_url_request_context.h @@ -211,7 +211,6 @@ class ChromeURLRequestContext : public URLRequestContext { bool is_off_the_record_; private: - DISALLOW_COPY_AND_ASSIGN(ChromeURLRequestContext); }; |