FBTF: Move more ctors/dtors from headers to implementation.

- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
  three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
  shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
  negligible; there were only a few classes that had a Timer but had a
  ctor/dtor in the header after the previous cleanups.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3278006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 15 insertions, 7 deletions

diff --git a/chrome/browser/net/sdch_dictionary_fetcher.cc b/chrome/browser/net/sdch_dictionary_fetcher.cc
index ed24b8b..04542a6 100644
--- a/chrome/browser/net/sdch_dictionary_fetcher.cc
+++ b/chrome/browser/net/sdch_dictionary_fetcher.cc
@@ -4,9 +4,18 @@
 
 #include "chrome/browser/net/sdch_dictionary_fetcher.h"
 
+#include "base/compiler_specific.h"
 #include "chrome/browser/profile.h"
 #include "net/url_request/url_request_status.h"
 
+SdchDictionaryFetcher::SdchDictionaryFetcher()
+    : ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
+      task_is_pending_(false) {
+}
+
+SdchDictionaryFetcher::~SdchDictionaryFetcher() {
+}
+
 void SdchDictionaryFetcher::Schedule(const GURL& dictionary_url) {
   // Avoid pushing duplicate copy onto queue.  We may fetch this url again later
   // and get a different dictionary, but there is no reason to have it in the
diff --git a/chrome/browser/net/sdch_dictionary_fetcher.h b/chrome/browser/net/sdch_dictionary_fetcher.h
index 886c980..32bf0d7 100644
--- a/chrome/browser/net/sdch_dictionary_fetcher.h
+++ b/chrome/browser/net/sdch_dictionary_fetcher.h
@@ -14,7 +14,6 @@
 #include <set>
 #include <string>
 
-#include "base/compiler_specific.h"
 #include "base/scoped_ptr.h"
 #include "base/task.h"
 #include "chrome/common/net/url_fetcher.h"
@@ -23,10 +22,8 @@
 class SdchDictionaryFetcher : public URLFetcher::Delegate,
                               public SdchFetcher {
  public:
-  SdchDictionaryFetcher() :
-      ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
-      task_is_pending_(false) {}
-  virtual ~SdchDictionaryFetcher() {}
+  SdchDictionaryFetcher();
+  virtual ~SdchDictionaryFetcher();
 
   // Implementation of SdchFetcher class.
   // This method gets the requested dictionary, and then calls back into the
@@ -87,7 +84,6 @@ class SdchDictionaryFetcher : public URLFetcher::Delegate,
   // TODO(jar): Try to augment the SDCH proposal to include this restiction.
   std::set<GURL> attempted_load_;
 
-
   DISALLOW_COPY_AND_ASSIGN(SdchDictionaryFetcher);
 };
 
diff --git a/chrome/browser/net/url_request_slow_http_job.cc b/chrome/browser/net/url_request_slow_http_job.cc
index 3d143b07..a8205f0 100644
--- a/chrome/browser/net/url_request_slow_http_job.cc
+++ b/chrome/browser/net/url_request_slow_http_job.cc
@@ -53,6 +53,9 @@ void URLRequestSlowHTTPJob::Start() {
                      &URLRequestSlowHTTPJob::RealStart);
 }
 
+URLRequestSlowHTTPJob::~URLRequestSlowHTTPJob() {
+}
+
 void URLRequestSlowHTTPJob::RealStart() {
   URLRequestMockHTTPJob::Start();
 }
diff --git a/chrome/browser/net/url_request_slow_http_job.h b/chrome/browser/net/url_request_slow_http_job.h
index 0362106..fab7a01 100644
--- a/chrome/browser/net/url_request_slow_http_job.h
+++ b/chrome/browser/net/url_request_slow_http_job.h
@@ -28,7 +28,7 @@ class URLRequestSlowHTTPJob : public URLRequestMockHTTPJob {
   virtual void Start();
 
  private:
-  ~URLRequestSlowHTTPJob() {}
+  ~URLRequestSlowHTTPJob();
 
   void RealStart();