diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-13 19:39:58 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-13 19:39:58 +0000 |
commit | e23d3a394aed0b7f353edfeaac2fc2181085c8ff (patch) | |
tree | e5ae26a74ec8fa098aab0e9837ad8d4434ab6b08 /chrome/browser/notifications/desktop_notification_service.cc | |
parent | 997e70b24b8041d402f759587b8ce01c56f55c0b (diff) | |
download | chromium_src-e23d3a394aed0b7f353edfeaac2fc2181085c8ff.zip chromium_src-e23d3a394aed0b7f353edfeaac2fc2181085c8ff.tar.gz chromium_src-e23d3a394aed0b7f353edfeaac2fc2181085c8ff.tar.bz2 |
Convert infobar APIs to UTF-16.
The critical change is the base class in infobar_delegate.h.
The remainder is just adapting all users to that change.
I grepped for all instances of the three base functions whose
types I changed to be more sure that I found all classes that
tried to overload these functions. I sure wish C++ had an
@Override annotation. :~(
TEST=compiles
BUG=23581
Review URL: http://codereview.chromium.org/3127009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56066 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications/desktop_notification_service.cc')
-rw-r--r-- | chrome/browser/notifications/desktop_notification_service.cc | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc index 0f86e26..8059e1e 100644 --- a/chrome/browser/notifications/desktop_notification_service.cc +++ b/chrome/browser/notifications/desktop_notification_service.cc @@ -117,7 +117,7 @@ class NotificationPermissionInfoBarDelegate : public ConfirmInfoBarDelegate { public: NotificationPermissionInfoBarDelegate(TabContents* contents, const GURL& origin, - const std::wstring& display_name, + const string16& display_name, int process_id, int route_id, int callback_context) @@ -144,8 +144,9 @@ class NotificationPermissionInfoBarDelegate : public ConfirmInfoBarDelegate { delete this; } - virtual std::wstring GetMessageText() const { - return l10n_util::GetStringF(IDS_NOTIFICATION_PERMISSIONS, display_name_); + virtual string16 GetMessageText() const { + return l10n_util::GetStringFUTF16(IDS_NOTIFICATION_PERMISSIONS, + display_name_); } virtual SkBitmap* GetIcon() const { @@ -157,10 +158,10 @@ class NotificationPermissionInfoBarDelegate : public ConfirmInfoBarDelegate { return BUTTON_OK | BUTTON_CANCEL | BUTTON_OK_DEFAULT; } - virtual std::wstring GetButtonLabel(InfoBarButton button) const { + virtual string16 GetButtonLabel(InfoBarButton button) const { return button == BUTTON_OK ? - l10n_util::GetString(IDS_NOTIFICATION_PERMISSION_YES) : - l10n_util::GetString(IDS_NOTIFICATION_PERMISSION_NO); + l10n_util::GetStringUTF16(IDS_NOTIFICATION_PERMISSION_YES) : + l10n_util::GetStringUTF16(IDS_NOTIFICATION_PERMISSION_NO); } virtual bool Accept() { @@ -186,7 +187,7 @@ class NotificationPermissionInfoBarDelegate : public ConfirmInfoBarDelegate { // The display name for the origin to be displayed. Will be different from // origin_ for extensions. - std::wstring display_name_; + string16 display_name_; // The Profile that we restore sessions from. Profile* profile_; @@ -517,10 +518,9 @@ void DesktopNotificationService::RequestPermission( ContentSetting setting = GetContentSetting(origin); if (setting == CONTENT_SETTING_ASK) { // Show an info bar requesting permission. - std::wstring display_name = UTF16ToWide(DisplayNameForOrigin(origin)); - tab->AddInfoBar(new NotificationPermissionInfoBarDelegate( - tab, origin, display_name, process_id, route_id, callback_context)); + tab, origin, DisplayNameForOrigin(origin), process_id, + route_id, callback_context)); } else { // Notify renderer immediately. ChromeThread::PostTask( |