summaryrefslogtreecommitdiffstats
path: root/chrome/browser/notifications/notification.h
diff options
context:
space:
mode:
authorpeter <peter@chromium.org>2015-03-06 12:34:54 -0800
committerCommit bot <commit-bot@chromium.org>2015-03-06 20:36:11 +0000
commit7ff964b32356c894aec808cd7d3c30de55c45dc3 (patch)
treeb8c1d15ca385abec0aea93af7c256ebeac4b2665 /chrome/browser/notifications/notification.h
parentad1e6fef08b3b2d0e372e8597fe362657ea0a11d (diff)
downloadchromium_src-7ff964b32356c894aec808cd7d3c30de55c45dc3.zip
chromium_src-7ff964b32356c894aec808cd7d3c30de55c45dc3.tar.gz
chromium_src-7ff964b32356c894aec808cd7d3c30de55c45dc3.tar.bz2
Change Notification.replace_id() to be a std::string(), rename to tag().
This renames Notification.replace_id() to be called tag() instead, in line with the Web Notification API and Android, and changes it to be an std::string rather than a base::string16. BUG=456882 Review URL: https://codereview.chromium.org/976753002 Cr-Commit-Position: refs/heads/master@{#319486}
Diffstat (limited to 'chrome/browser/notifications/notification.h')
-rw-r--r--chrome/browser/notifications/notification.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h
index f2afac4..f8f7690 100644
--- a/chrome/browser/notifications/notification.h
+++ b/chrome/browser/notifications/notification.h
@@ -28,7 +28,7 @@ class Notification : public message_center::Notification {
const base::string16& body,
const gfx::Image& icon,
const base::string16& display_source,
- const base::string16& replace_id,
+ const std::string& tag,
NotificationDelegate* delegate);
Notification(
@@ -39,7 +39,7 @@ class Notification : public message_center::Notification {
const gfx::Image& icon,
const message_center::NotifierId& notifier_id,
const base::string16& display_source,
- const base::string16& replace_id,
+ const std::string& tag,
const message_center::RichNotificationData& rich_notification_data,
NotificationDelegate* delegate);
@@ -53,7 +53,7 @@ class Notification : public message_center::Notification {
const GURL& origin_url() const { return origin_url_; }
// A unique identifier used to update (replace) or remove a notification.
- const base::string16& replace_id() const { return replace_id_; }
+ const std::string& tag() const { return tag_; }
// Id of the delegate embedded inside this instance.
std::string delegate_id() const { return delegate()->id(); }
@@ -64,8 +64,8 @@ class Notification : public message_center::Notification {
// The Origin of the page/worker which created this notification.
GURL origin_url_;
- // The user-supplied replace ID for the notification.
- base::string16 replace_id_;
+ // The user-supplied tag for the notification.
+ std::string tag_;
// A proxy object that allows access back to the JavaScript object that
// represents the notification, for firing events.