diff options
| author | derat@chromium.org <derat@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 00:51:09 +0000 |
|---|---|---|
| committer | derat@chromium.org <derat@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 00:51:09 +0000 |
| commit | ca5660e1598b86264d93b3dd8ef94f3586e36ad5 (patch) | |
| tree | d806b8134681cc58cce25ac8a3f76f787dcabab9 /chrome/browser/notifications | |
| parent | 890255a21fc347044ad627abc1fb75230586e819 (diff) | |
| download | chromium_src-ca5660e1598b86264d93b3dd8ef94f3586e36ad5.zip chromium_src-ca5660e1598b86264d93b3dd8ef94f3586e36ad5.tar.gz chromium_src-ca5660e1598b86264d93b3dd8ef94f3586e36ad5.tar.bz2 | |
gtk: Improve fullscreen RenderWidgetHostViewGtk.
This was previously using the same code as for popup windows
(i.e. <select> and autocomplete), which creates an
override-redirect/popup window and grabs the pointer and
keyboard. This is the wrong way to make a window
fullscreen: since the window is override-redirect, the
window manager will ignore the fullscreen request, and since
the input is grabbed, other X clients' key grabs (such as
Alt-Tab) won't work.
This change makes us instead open a regular toplevel window.
BUG=chromium-os:11545
TEST=checked that brightness and volume keys work while Pepper Flash is fullscreen and that <select> popups still work
Review URL: http://codereview.chromium.org/6462017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications')
| -rw-r--r-- | chrome/browser/notifications/balloon_host.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/notifications/balloon_host.h b/chrome/browser/notifications/balloon_host.h index fc576c4..fde33b5 100644 --- a/chrome/browser/notifications/balloon_host.h +++ b/chrome/browser/notifications/balloon_host.h @@ -73,8 +73,7 @@ class BalloonHost : public RenderViewHostDelegate, int route_id, const ViewHostMsg_CreateWindow_Params& params); virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type) {} - virtual void CreateNewFullscreenWidget( - int route_id, WebKit::WebPopupType popup_type) {} + virtual void CreateNewFullscreenWidget(int route_id) {} virtual void ShowCreatedWindow(int route_id, WindowOpenDisposition disposition, const gfx::Rect& initial_pos, |