diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 22:23:20 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 22:23:20 +0000 |
| commit | 225c8f507421a2eff2ed7a900104431d04ed7e5e (patch) | |
| tree | 770b7081fc8f2a15abe4635938e03550f010a526 /chrome/browser/notifications | |
| parent | f3f0c05dfbcbfec2ecbb79ba9bab6ffc8f93ea32 (diff) | |
| download | chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.zip chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.tar.gz chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.tar.bz2 | |
linux: build with -Wextra
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications')
| -rw-r--r-- | chrome/browser/notifications/balloon_collection.cc | 7 | ||||
| -rw-r--r-- | chrome/browser/notifications/balloon_collection.h | 4 |
2 files changed, 5 insertions, 6 deletions
diff --git a/chrome/browser/notifications/balloon_collection.cc b/chrome/browser/notifications/balloon_collection.cc index e148911..224e7bb 100644 --- a/chrome/browser/notifications/balloon_collection.cc +++ b/chrome/browser/notifications/balloon_collection.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -121,9 +121,8 @@ BalloonCollectionImpl::Layout::Layout() { RefreshSystemMetrics(); } -const void BalloonCollectionImpl::Layout::GetMaxLinearSize( - int* max_balloon_size, - int* total_size) const { +void BalloonCollectionImpl::Layout::GetMaxLinearSize(int* max_balloon_size, + int* total_size) const { DCHECK(max_balloon_size && total_size); switch (placement_) { diff --git a/chrome/browser/notifications/balloon_collection.h b/chrome/browser/notifications/balloon_collection.h index 8810b18..14469d9 100644 --- a/chrome/browser/notifications/balloon_collection.h +++ b/chrome/browser/notifications/balloon_collection.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -94,7 +94,7 @@ class BalloonCollectionImpl : public BalloonCollection { // // The size may be a height or length depending on the way that // balloons are laid out. - const void GetMaxLinearSize(int* max_balloon_size, int* total_size) const; + void GetMaxLinearSize(int* max_balloon_size, int* total_size) const; // Refresh the cached values for work area and drawing metrics. // The application should call this method to re-acquire metrics after |