diff options
| author | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 17:54:08 +0000 |
|---|---|---|
| committer | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 17:54:08 +0000 |
| commit | caf706f870d1d9d576277110ab1df022b2756203 (patch) | |
| tree | 6a890ba2ebeb302c6cdff569d462288a9676d811 /chrome/browser/notifications | |
| parent | 8e23c49777ff4b57fa17f9d5eba8ccd82784e010 (diff) | |
| download | chromium_src-caf706f870d1d9d576277110ab1df022b2756203.zip chromium_src-caf706f870d1d9d576277110ab1df022b2756203.tar.gz chromium_src-caf706f870d1d9d576277110ab1df022b2756203.tar.bz2 | |
Refactoring select popup on Mac.
The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection.
BUG=None
TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups).
Original review:
http://codereview.chromium.org/3795006/show
Review URL: http://codereview.chromium.org/4078003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications')
| -rw-r--r-- | chrome/browser/notifications/balloon_host.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/chrome/browser/notifications/balloon_host.h b/chrome/browser/notifications/balloon_host.h index 1c8b088..09d54ea 100644 --- a/chrome/browser/notifications/balloon_host.h +++ b/chrome/browser/notifications/balloon_host.h @@ -7,6 +7,7 @@ #pragma once #include <string> +#include <vector> #include "chrome/browser/extensions/extension_function_dispatcher.h" #include "chrome/browser/notifications/balloon.h" @@ -77,6 +78,12 @@ class BalloonHost : public RenderViewHostDelegate, const gfx::Rect& initial_pos) {} virtual void ShowCreatedFullscreenWidget(int route_id) {} virtual void ShowContextMenu(const ContextMenuParams& params) {} + virtual void ShowPopupMenu(const gfx::Rect& bounds, + int item_height, + double item_font_size, + int selected_item, + const std::vector<WebMenuItem>& items, + bool right_aligned) {} virtual void StartDragging(const WebDropData& drop_data, WebKit::WebDragOperationsMask allowed_ops) {} virtual void StartDragging(const WebDropData&, |